mirror of
https://github.com/fleetdm/fleet
synced 2026-05-09 10:11:03 +00:00
For #23243 # Checklist for submitter <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated automated tests - [ ] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality ## Details This PR updates the policy Manage Automations modals to support pagination. Previously, these modals received a list of policies from the main Manage Policies page, which is itself paginated, so that a user could only add automations to whatever policies were currently listed on the Manage Automations page. This PR does some refactoring via the creation of a new PaginatedList component which: * accepts a `fetchPage` property it can call to get a page of data, * renders the data in a list with checkboxes and optional custom markup (e.g. dropdowns) * keeps track of changed ("dirty") items in the list, even across page changes * allows parent components to access the list of dirty items via a React `ref` For this specific use case, there's also a new `PoliciesPaginatedList` which implements the `fetchPage` for getting a page of policies, and adds Save and Cancel buttons. Each of the updated modals uses `PoliciesPaginatedList` to replace its current code for rendering policies in a list, and delegates much of the logic around change tracking to the new components.
161 lines
4.5 KiB
TypeScript
161 lines
4.5 KiB
TypeScript
import React, { ReactNode, KeyboardEvent, useEffect, useRef } from "react";
|
|
import classnames from "classnames";
|
|
import { noop, pick } from "lodash";
|
|
|
|
import FormField from "components/forms/FormField";
|
|
import { IFormFieldProps } from "components/forms/FormField/FormField";
|
|
import TooltipWrapper from "components/TooltipWrapper";
|
|
import Icon from "components/Icon";
|
|
|
|
const baseClass = "fleet-checkbox";
|
|
|
|
export interface ICheckboxProps {
|
|
children?: ReactNode;
|
|
className?: string;
|
|
/** readOnly displays a non-editable field */
|
|
readOnly?: boolean;
|
|
/** disabled displays a greyed out non-editable field */
|
|
disabled?: boolean;
|
|
name?: string;
|
|
onChange?: any; // TODO: meant to be an event; figure out type for this
|
|
onBlur?: (event: React.FocusEvent<HTMLDivElement>) => void;
|
|
value?: boolean | null;
|
|
wrapperClassName?: string;
|
|
indeterminate?: boolean;
|
|
parseTarget?: boolean;
|
|
tooltipContent?: React.ReactNode;
|
|
isLeftLabel?: boolean;
|
|
helpText?: React.ReactNode;
|
|
/** Use in table action only
|
|
* Do not use on forms as enter key reserved for submit */
|
|
enableEnterToCheck?: boolean;
|
|
}
|
|
|
|
const Checkbox = (props: ICheckboxProps) => {
|
|
const {
|
|
children,
|
|
className,
|
|
readOnly = false,
|
|
disabled = false,
|
|
name,
|
|
onChange = noop,
|
|
onBlur = noop,
|
|
value = false,
|
|
wrapperClassName,
|
|
indeterminate = false,
|
|
parseTarget,
|
|
tooltipContent,
|
|
isLeftLabel,
|
|
helpText,
|
|
enableEnterToCheck = false,
|
|
} = props;
|
|
|
|
const inputRef = useRef<HTMLInputElement>(null);
|
|
|
|
useEffect(() => {
|
|
if (inputRef.current) {
|
|
inputRef.current.indeterminate = indeterminate;
|
|
}
|
|
}, [indeterminate]);
|
|
|
|
const handleChange = (
|
|
event: React.MouseEvent | React.KeyboardEvent
|
|
): void => {
|
|
event.preventDefault();
|
|
if (readOnly || disabled) return;
|
|
|
|
// If indeterminate, set to true; otherwise, toggle the current value
|
|
const newValue = indeterminate || !value;
|
|
|
|
if (parseTarget) {
|
|
onChange({ name, value: newValue });
|
|
} else {
|
|
onChange(newValue);
|
|
}
|
|
|
|
// Update the hidden input
|
|
if (inputRef.current) {
|
|
inputRef.current.checked = newValue;
|
|
}
|
|
};
|
|
|
|
/** Manual implementation of spacebar toggling checkboxes (default behavior)
|
|
* since we're using a custom div instead of a native checkbox
|
|
* Enter key intended to toggle table checkboxes only */
|
|
const handleKeyDown = (event: KeyboardEvent<HTMLDivElement>): void => {
|
|
if (event.key === " " || (enableEnterToCheck && event.key === "Enter")) {
|
|
handleChange(event);
|
|
}
|
|
};
|
|
|
|
const checkBoxClass = classnames(
|
|
{ inverse: isLeftLabel },
|
|
className,
|
|
baseClass
|
|
);
|
|
|
|
const checkBoxLabelClass = classnames(checkBoxClass, {
|
|
[`${baseClass}__label--read-only`]: readOnly || disabled,
|
|
[`${baseClass}__label--disabled`]: disabled,
|
|
});
|
|
|
|
const formFieldProps = {
|
|
...pick(props, ["helpText", "label", "error", "name"]),
|
|
className: wrapperClassName,
|
|
type: "checkbox",
|
|
} as IFormFieldProps;
|
|
|
|
const getIconName = () => {
|
|
if (indeterminate) return "checkbox-indeterminate";
|
|
if (value) return "checkbox";
|
|
return "checkbox-unchecked";
|
|
};
|
|
|
|
return (
|
|
<FormField {...formFieldProps}>
|
|
<label htmlFor={name}>
|
|
<input
|
|
type="checkbox"
|
|
ref={inputRef}
|
|
name={name}
|
|
checked={!!value}
|
|
onChange={noop} // Empty onChange to avoid React warning
|
|
disabled={disabled || readOnly}
|
|
style={{ display: "none" }} // Hide the input
|
|
id={name}
|
|
/>
|
|
<div
|
|
role="checkbox"
|
|
aria-label={name}
|
|
aria-checked={indeterminate ? "mixed" : value || undefined}
|
|
aria-readonly={readOnly}
|
|
aria-disabled={disabled}
|
|
tabIndex={disabled ? -1 : 0}
|
|
className={checkBoxLabelClass}
|
|
onClick={handleChange}
|
|
onKeyDown={handleKeyDown}
|
|
onBlur={onBlur}
|
|
>
|
|
<Icon
|
|
name={getIconName()}
|
|
className={`${baseClass}__icon ${baseClass}__icon--${getIconName()}`}
|
|
/>
|
|
{tooltipContent ? (
|
|
<span className={`${baseClass}__label-tooltip tooltip`}>
|
|
<TooltipWrapper
|
|
tipContent={tooltipContent}
|
|
clickable={false} // Not block form behind tooltip
|
|
>
|
|
{children}
|
|
</TooltipWrapper>
|
|
</span>
|
|
) : (
|
|
<span className={`${baseClass}__label`}>{children}</span>
|
|
)}
|
|
</div>
|
|
</label>
|
|
</FormField>
|
|
);
|
|
};
|
|
|
|
export default Checkbox;
|