mirror of
https://github.com/fleetdm/fleet
synced 2026-05-17 22:18:39 +00:00
a2468fa0b4
#23258 (see [comment](https://github.com/fleetdm/fleet/issues/23258#issuecomment-2443304838) for rationale) Validated by removing the two places that would create the directory (early in scanVulnerabilities in cron.go, partway through download in download.go) and ensuring the test failed (timeout after 10s). Both dir creations happen early in the vulns cron so I was able to drastically tighten the timing on the periodic check on this test, so this tests completes way quicker than before as an added benefit (automatic test parallelism notwithstanding). The panic recovery here theoretically shouldn't be necessary, as on a passed test the context will get cancelled while syncing the CPE sqlite, but is included to ensure the test doesn't flake if the implementation of the vulnerabilities cron changes such that we _would_ get a panic by cancelling the context this early. # Checklist for submitter - [x] Added/updated tests |
||
|---|---|---|
| .. | ||
| cpe | ||
| cve | ||
| fleet | ||
| fleetctl | ||
| macoffice | ||
| msrc | ||
| osquery-perf | ||