mirror of
https://github.com/fleetdm/fleet
synced 2026-04-21 13:37:30 +00:00
79b7d83bf5
**Related issue:** Resolves #32999 - Enhanced internal code quality tooling by implementing a custom linting build configuration. - Updated continuous integration workflow to utilize the new custom build process for improved code analysis and consistency checks. ### Confirmed that running local custom `golangci-lint` build with `nilaway` plugin catches lots of issues when run on `fleet/`: <img width="1555" height="939" alt="Screenshot 2026-01-29 at 2 47 50 PM" src="https://github.com/user-attachments/assets/c6a18400-fdf0-4104-97d8-e117efc28ed6" /> <img width="301" height="109" alt="Screenshot 2026-01-29 at 2 48 36 PM" src="https://github.com/user-attachments/assets/b459ee7b-b391-457a-9191-17d56a80c783" /> ### Confirmed that new incremental CI step using custom `golangci-lint` build with `nilaway` plugin _does not_ check any `.go` files when none have been modified, and so passes successfully (incremental check works as expected): <img width="337" height="197" alt="Screenshot 2026-01-29 at 2 45 24 PM" src="https://github.com/user-attachments/assets/c7ae585e-2e10-4ebf-a3a3-96c26063f1e4" /> ### Confirmed that new incremental CI step using custom `golangci-lint` build with `nilaway` plugin _does_ check modified lines of `.go` files, and so successfully flags a potentially unsafe dereference and fails the job (incremental check works as expected): <img width="825" height="491" alt="Screenshot 2026-01-29 at 5 50 01 PM" src="https://github.com/user-attachments/assets/82bc5616-6fb9-4357-b8bc-c7eebc42c2d8" /> ### Honorable mention: `nilaway` agrees that `listHostSoftware` is a wild beast: <img width="1277" height="190" alt="Screenshot 2026-01-29 at 5 52 32 PM" src="https://github.com/user-attachments/assets/dfade2a8-fbcc-4bae-98f9-6bf1089620d2" /> - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Fleet dev cycle reliability improvements** <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Victor Lyuboslavsky <2685025+getvictor@users.noreply.github.com>
126 lines
2.3 KiB
Text
126 lines
2.3 KiB
Text
# binaries
|
|
*.exe
|
|
|
|
# output directories
|
|
/build
|
|
vendor
|
|
node_modules
|
|
dist
|
|
|
|
# generated artifacts
|
|
assets/bundle*.*
|
|
assets/*@*.svg
|
|
assets/*@*.png
|
|
assets/*@*.gif
|
|
assets/*@*.eot
|
|
assets/*@*.woff
|
|
assets/*@*.woff2
|
|
assets/*@*.ttf
|
|
assets/*@*.mp4
|
|
frontend/templates/react.tmpl
|
|
bindata.go
|
|
server/bindata/generated.go
|
|
*.cover
|
|
*.test
|
|
*.log
|
|
coverage.txt
|
|
storybook-static
|
|
frontend/coverage
|
|
|
|
# typescript generated test files
|
|
tmp/
|
|
|
|
# test debug files
|
|
debug.test*
|
|
|
|
# operating system artifacts
|
|
.DS_Store
|
|
|
|
# test mysql server data
|
|
mysqldata/
|
|
|
|
# test helm charts
|
|
helm-temp
|
|
charts/fleet/charts
|
|
|
|
#editors
|
|
.idea
|
|
.swp
|
|
|
|
# Fleet local development DB backups
|
|
backup.sql.gz
|
|
|
|
# Common mistake for new developers to run npm install and then end up
|
|
# committing a package-lock.json. Fleet app uses Yarn with yarn.lock.
|
|
package-lock.json
|
|
|
|
# infra
|
|
.terraform
|
|
.terraform.tfstate*
|
|
terraform.tfstate*
|
|
|
|
# generated orbit installers and artifacts
|
|
fleet-osquery*
|
|
desktop.app.tar.gz
|
|
osqueryd.app.tar.gz
|
|
desktop.tar.gz
|
|
nudge.app.tar.gz
|
|
swiftDialog.app.tar.gz
|
|
|
|
# residual files when running the cpe command
|
|
cmd/cpe/etagenv
|
|
cmd/cpe/cpe*.sqlite
|
|
cmd/cpe/cpe*.sqlite.gz
|
|
|
|
# Testing TUF server
|
|
test_tuf
|
|
|
|
# Residual files when running the msrc generate command
|
|
msrc_in/
|
|
msrc_out/
|
|
|
|
# Residual files when running cmd/macoffice/generate.go
|
|
macoffice_rel_notes/
|
|
|
|
# Keys and certificates that may be generated in the root of the repo
|
|
# (e.g. with ./build/fleetctl generate ...).
|
|
/*.key
|
|
/*.crt
|
|
|
|
# IDE
|
|
.vscode
|
|
.cursor
|
|
|
|
# residual files when running the build-windows tool
|
|
orbit/cmd/desktop/manifest.xml
|
|
orbit/cmd/desktop/resource_windows.syso
|
|
orbit/cmd/orbit/manifest.xml
|
|
orbit/cmd/orbit/resource_windows.syso
|
|
|
|
# Residual files from osqueryd loadtests.
|
|
osquery_worker_*.jpg
|
|
|
|
# Residual files when building fleetd_tables extension.
|
|
fleetd_tables_*
|
|
|
|
# Location of test extensions executables
|
|
tools/test_extensions/hello_world/macos
|
|
tools/test_extensions/hello_world/linux
|
|
tools/test_extensions/hello_world/linux-arm64
|
|
tools/test_extensions/hello_world/windows
|
|
tools/test_extensions/hello_world/windows-arm64
|
|
|
|
# Residual files when building fleet_tables extension.
|
|
fleet_tables_*.ext
|
|
|
|
# Local dev files
|
|
.env
|
|
.tool-versions
|
|
.zed/
|
|
third_party/vuln-check/go.sum
|
|
|
|
# Required to not make `fleet-desktop` macOS executable built with a `dirty` flag (see #35006).
|
|
Fleet\ Desktop.app
|
|
|
|
# custom golangci-lint executable
|
|
custom-gcl
|