mirror of
https://github.com/fleetdm/fleet
synced 2026-05-24 09:28:54 +00:00
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #41385 # Details This PR updates `fleetctl` to use the new API urls and params when communicating with Fleet server. This avoids deprecation warnings showing up on the server that users won't be able to fix. Most of the changes are straightforward `team_id` -> `fleet_id`. A couple of code changes have been pointed out. The most interesting is in icon URLs, which can be persisted in the database (so we'll need to do a migration in Fleet 5 if we want to drop support for `team_id`. Similarly the FMA download urls are briefly persisted in the db for the purpose of sending MDM commands. If we drop team_id support in Fleet 5 there could be a brief window where there are unprocessed commands in the db still with `team_id` in them, so we'll probably want to migrate those as well. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. n/a - all internal ## Testing - [X] Added/updated automated tests - [X] QA'd all new/changed functionality manually - [X] ran `fleetctl gitops` on main and saw a bunch of deprecation warnings, ran it on this branch and the warnings were gone 💨 - [X] same with `fleetctl generate-gitops` - [X] ran `fleetctl get` commands and verified that the new URLs and params were used - [X] ran `fleetctl apply` commands and verified that the new URLs and params were used
433 lines
13 KiB
Go
433 lines
13 KiB
Go
package worker
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"log/slog"
|
|
"sort"
|
|
"sync"
|
|
"text/template"
|
|
"time"
|
|
|
|
"github.com/fleetdm/fleet/v4/server/contexts/ctxerr"
|
|
"github.com/fleetdm/fleet/v4/server/contexts/license"
|
|
"github.com/fleetdm/fleet/v4/server/fleet"
|
|
"github.com/fleetdm/fleet/v4/server/service/externalsvc"
|
|
zendesk "github.com/nukosuke/go-zendesk/zendesk"
|
|
)
|
|
|
|
// zendeskName is the name of the job as registered in the worker.
|
|
const zendeskName = "zendesk"
|
|
|
|
var zendeskTemplates = struct {
|
|
VulnSummary *template.Template
|
|
VulnDescription *template.Template
|
|
FailingPolicySummary *template.Template
|
|
FailingPolicyDescription *template.Template
|
|
}{
|
|
VulnSummary: template.Must(template.New("").Parse(
|
|
`Vulnerability {{ .CVE }} detected on {{ len .Hosts }} host(s)`,
|
|
)),
|
|
|
|
// Zendesk uses markdown for formatting. Some reference documentation about
|
|
// it can be found here:
|
|
// https://support.zendesk.com/hc/en-us/articles/4408846544922-Formatting-text-with-Markdown
|
|
VulnDescription: template.Must(template.New("").Funcs(template.FuncMap{
|
|
// CISAKnownExploit is *bool, so any condition check on it in the template
|
|
// will test if nil or not, and not its actual boolean value. Hence, "deref".
|
|
"deref": func(b *bool) bool { return *b },
|
|
}).Parse(
|
|
`See vulnerability (CVE) details in National Vulnerability Database (NVD) here: [{{ .CVE }}]({{ .NVDURL }}{{ .CVE }}).
|
|
|
|
{{ if .IsPremium }}{{ if .EPSSProbability }}
|
|
|
|
Probability of exploit (reported by [FIRST.org/epss](https://www.first.org/epss/)): {{ .EPSSProbability }}
|
|
{{ end }}
|
|
{{ if .CVSSScore }}CVSS score (reported by [NVD](https://nvd.nist.gov/)): {{ .CVSSScore }}
|
|
{{ end }}
|
|
{{ if .CVEPublished }}Published (reported by [NVD|https://nvd.nist.gov/]): {{ .CVEPublished }}
|
|
{{ end }}
|
|
{{ if .CISAKnownExploit }}Known exploits (reported by [CISA](https://www.cisa.gov/known-exploited-vulnerabilities-catalog)): {{ if deref .CISAKnownExploit }}Yes{{ else }}No{{ end }}
|
|
|
|
{{ end }}{{ end }}
|
|
|
|
Affected hosts:
|
|
|
|
{{ $end := len .Hosts }}{{ if gt $end 50 }}{{ $end = 50 }}{{ end }}
|
|
{{ range slice .Hosts 0 $end }}
|
|
* [{{ .DisplayName }}]({{ $.FleetURL }}/hosts/{{ .ID }})
|
|
{{ range $path := .SoftwareInstalledPaths }}
|
|
* {{ $path }}
|
|
{{ end }}
|
|
{{ end }}
|
|
|
|
View the affected software and more affected hosts:
|
|
|
|
1. Go to the [Software]({{ .FleetURL }}/software/manage) page in Fleet.
|
|
2. Above the list of software, in the **Search software** box, enter "{{ .CVE }}".
|
|
3. Hover over the affected software and select **View all hosts**.
|
|
|
|
----
|
|
|
|
This ticket was created automatically by your Fleet Zendesk integration.
|
|
`)),
|
|
|
|
FailingPolicySummary: template.Must(template.New("").Parse(
|
|
`{{ .PolicyName }} policy failed on {{ len .Hosts }} host(s)`,
|
|
)),
|
|
|
|
FailingPolicyDescription: template.Must(template.New("").Parse(
|
|
`{{ if .PolicyCritical }}This policy is marked as **Critical** in Fleet.
|
|
|
|
{{ end }}Hosts:
|
|
{{ $end := len .Hosts }}{{ if gt $end 50 }}{{ $end = 50 }}{{ end }}
|
|
{{ range slice .Hosts 0 $end }}
|
|
* [{{ .DisplayName }}]({{ $.FleetURL }}/hosts/{{ .ID }})
|
|
{{ end }}
|
|
|
|
View hosts that failed {{ .PolicyName }} on the [**Hosts**]({{ .FleetURL }}/hosts/manage/?order_key=hostname&order_direction=asc&{{ if .TeamID }}fleet_id={{ .TeamID }}&{{ end }}policy_id={{ .PolicyID }}&policy_response=failing) page in Fleet.
|
|
|
|
----
|
|
|
|
This issue was created automatically by your Fleet Zendesk integration.
|
|
`)),
|
|
}
|
|
|
|
type zendeskVulnTplArgs struct {
|
|
NVDURL string
|
|
FleetURL string
|
|
CVE string
|
|
Hosts []fleet.HostVulnerabilitySummary
|
|
|
|
IsPremium bool
|
|
|
|
// the following fields are only included in the ticket for premium licenses.
|
|
EPSSProbability *float64
|
|
CVSSScore *float64
|
|
CISAKnownExploit *bool
|
|
CVEPublished *time.Time
|
|
}
|
|
|
|
// ZendeskClient defines the method required for the client that makes API calls
|
|
// to Zendesk.
|
|
type ZendeskClient interface {
|
|
CreateZendeskTicket(ctx context.Context, ticket *zendesk.Ticket) (*zendesk.Ticket, error)
|
|
ZendeskConfigMatches(opts *externalsvc.ZendeskOptions) bool
|
|
}
|
|
|
|
// Zendesk is the job processor for zendesk integrations.
|
|
type Zendesk struct {
|
|
FleetURL string
|
|
Datastore fleet.Datastore
|
|
Log *slog.Logger
|
|
NewClientFunc func(*externalsvc.ZendeskOptions) (ZendeskClient, error)
|
|
|
|
// mu protects concurrent access to clientsCache, so that the job processor
|
|
// can potentially be run concurrently.
|
|
mu sync.Mutex
|
|
// map of integration type + team ID to Zendesk client (empty team ID for
|
|
// global), e.g. "vuln:123", "failingPolicy:", etc.
|
|
clientsCache map[string]ZendeskClient
|
|
}
|
|
|
|
// returns nil, nil if there is no integration enabled for that message.
|
|
func (z *Zendesk) getClient(ctx context.Context, args zendeskArgs) (ZendeskClient, error) {
|
|
var teamID uint
|
|
var useTeamCfg bool
|
|
|
|
intgType := args.integrationType()
|
|
key := intgType + ":"
|
|
if intgType == intgTypeFailingPolicy && args.FailingPolicy.TeamID != nil {
|
|
teamID = *args.FailingPolicy.TeamID
|
|
useTeamCfg = true
|
|
key += fmt.Sprint(teamID)
|
|
}
|
|
|
|
ac, err := z.Datastore.AppConfig(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// load the config that would be used to create the client first - it is
|
|
// needed to check if an existing client is configured the same or if its
|
|
// configuration has changed since it was created.
|
|
var opts *externalsvc.ZendeskOptions
|
|
if useTeamCfg {
|
|
tm, err := z.Datastore.TeamLite(ctx, teamID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
intgs, err := tm.Config.Integrations.MatchWithIntegrations(ac.Integrations)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
for _, intg := range intgs.Zendesk {
|
|
if intgType == intgTypeFailingPolicy && intg.EnableFailingPolicies {
|
|
opts = &externalsvc.ZendeskOptions{
|
|
URL: intg.URL,
|
|
Email: intg.Email,
|
|
APIToken: intg.APIToken,
|
|
GroupID: intg.GroupID,
|
|
}
|
|
break
|
|
}
|
|
}
|
|
} else {
|
|
for _, intg := range ac.Integrations.Zendesk {
|
|
if (intgType == intgTypeVuln && intg.EnableSoftwareVulnerabilities) ||
|
|
(intgType == intgTypeFailingPolicy && intg.EnableFailingPolicies) {
|
|
opts = &externalsvc.ZendeskOptions{
|
|
URL: intg.URL,
|
|
Email: intg.Email,
|
|
APIToken: intg.APIToken,
|
|
GroupID: intg.GroupID,
|
|
}
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
z.mu.Lock()
|
|
defer z.mu.Unlock()
|
|
|
|
if z.clientsCache == nil {
|
|
z.clientsCache = make(map[string]ZendeskClient)
|
|
}
|
|
if opts == nil {
|
|
// no integration configured, clear any existing one
|
|
delete(z.clientsCache, key)
|
|
return nil, nil
|
|
}
|
|
|
|
// check if the existing one can be reused
|
|
if cli := z.clientsCache[key]; cli != nil && cli.ZendeskConfigMatches(opts) {
|
|
return cli, nil
|
|
}
|
|
|
|
// otherwise create a new one
|
|
cli, err := z.NewClientFunc(opts)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
z.clientsCache[key] = cli
|
|
return cli, nil
|
|
}
|
|
|
|
// Name returns the name of the job.
|
|
func (z *Zendesk) Name() string {
|
|
return zendeskName
|
|
}
|
|
|
|
// zendeskArgs are the arguments for the Zendesk integration job.
|
|
type zendeskArgs struct {
|
|
Vulnerability *vulnArgs `json:"vulnerability,omitempty"`
|
|
FailingPolicy *failingPolicyArgs `json:"failing_policy,omitempty"`
|
|
}
|
|
|
|
func (a *zendeskArgs) integrationType() string {
|
|
if a.FailingPolicy == nil {
|
|
return intgTypeVuln
|
|
}
|
|
return intgTypeFailingPolicy
|
|
}
|
|
|
|
// Run executes the zendesk job.
|
|
func (z *Zendesk) Run(ctx context.Context, argsJSON json.RawMessage) error {
|
|
var args zendeskArgs
|
|
if err := json.Unmarshal(argsJSON, &args); err != nil {
|
|
return ctxerr.Wrap(ctx, err, "unmarshal args")
|
|
}
|
|
|
|
cli, err := z.getClient(ctx, args)
|
|
if err != nil {
|
|
return ctxerr.Wrap(ctx, err, "get Zendesk client")
|
|
}
|
|
if cli == nil {
|
|
// this message was queued when an integration was enabled, but since
|
|
// then it has been disabled, so return success to mark the message
|
|
// as processed.
|
|
return nil
|
|
}
|
|
|
|
switch intgType := args.integrationType(); intgType {
|
|
case intgTypeVuln:
|
|
return z.runVuln(ctx, cli, args)
|
|
case intgTypeFailingPolicy:
|
|
return z.runFailingPolicy(ctx, cli, args)
|
|
default:
|
|
return ctxerr.Errorf(ctx, "unknown integration type: %v", intgType)
|
|
}
|
|
}
|
|
|
|
func (z *Zendesk) runVuln(ctx context.Context, cli ZendeskClient, args zendeskArgs) error {
|
|
vargs := args.Vulnerability
|
|
if vargs == nil {
|
|
return errors.New("invalid job args")
|
|
}
|
|
|
|
var hosts []fleet.HostVulnerabilitySummary
|
|
var err error
|
|
|
|
// Default to deprecated method in case we are processing an 'old' job payload
|
|
// we are deprecating this because of performance reasons - querying by software_id should be
|
|
// way more efficient than by CVE.
|
|
if len(vargs.AffectedSoftwareIDs) == 0 {
|
|
hosts, err = z.Datastore.HostsByCVE(ctx, vargs.CVE)
|
|
} else {
|
|
hosts, err = z.Datastore.HostVulnSummariesBySoftwareIDs(ctx, vargs.AffectedSoftwareIDs)
|
|
}
|
|
|
|
if err != nil {
|
|
return ctxerr.Wrap(ctx, err, "fetching hosts")
|
|
}
|
|
|
|
tplArgs := &zendeskVulnTplArgs{
|
|
NVDURL: nvdCVEURL,
|
|
FleetURL: z.FleetURL,
|
|
CVE: vargs.CVE,
|
|
Hosts: hosts,
|
|
IsPremium: license.IsPremium(ctx),
|
|
EPSSProbability: vargs.EPSSProbability,
|
|
CVSSScore: vargs.CVSSScore,
|
|
CISAKnownExploit: vargs.CISAKnownExploit,
|
|
CVEPublished: vargs.CVEPublished,
|
|
}
|
|
|
|
createdTicket, err := z.createTemplatedTicket(ctx, cli, zendeskTemplates.VulnSummary, zendeskTemplates.VulnDescription, tplArgs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
z.Log.DebugContext(ctx, "created zendesk ticket for cve",
|
|
"cve", vargs.CVE,
|
|
"ticket_id", createdTicket.ID,
|
|
)
|
|
return nil
|
|
}
|
|
|
|
func (z *Zendesk) runFailingPolicy(ctx context.Context, cli ZendeskClient, args zendeskArgs) error {
|
|
tplArgs := newFailingPoliciesTplArgs(z.FleetURL, args.FailingPolicy)
|
|
|
|
createdTicket, err := z.createTemplatedTicket(ctx, cli, zendeskTemplates.FailingPolicySummary, zendeskTemplates.FailingPolicyDescription, tplArgs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
attrs := []any{
|
|
"policy_id", args.FailingPolicy.PolicyID,
|
|
"policy_name", args.FailingPolicy.PolicyName,
|
|
"ticket_id", createdTicket.ID,
|
|
}
|
|
if args.FailingPolicy.TeamID != nil {
|
|
attrs = append(attrs, "team_id", *args.FailingPolicy.TeamID)
|
|
}
|
|
z.Log.DebugContext(ctx, "created zendesk ticket for failing policy", attrs...)
|
|
return nil
|
|
}
|
|
|
|
func (z *Zendesk) createTemplatedTicket(ctx context.Context, cli ZendeskClient, summaryTpl, descTpl *template.Template, args any) (*zendesk.Ticket, error) {
|
|
var buf bytes.Buffer
|
|
if err := summaryTpl.Execute(&buf, args); err != nil {
|
|
return nil, ctxerr.Wrap(ctx, err, "execute summary template")
|
|
}
|
|
summary := buf.String()
|
|
|
|
buf.Reset() // reuse buffer
|
|
if err := descTpl.Execute(&buf, args); err != nil {
|
|
return nil, ctxerr.Wrap(ctx, err, "execute description template")
|
|
}
|
|
description := buf.String()
|
|
|
|
ticket := &zendesk.Ticket{
|
|
Subject: summary,
|
|
Comment: &zendesk.TicketComment{Body: description},
|
|
}
|
|
|
|
createdTicket, err := cli.CreateZendeskTicket(ctx, ticket)
|
|
if err != nil {
|
|
return nil, ctxerr.Wrap(ctx, err, "create ticket")
|
|
}
|
|
return createdTicket, nil
|
|
}
|
|
|
|
// QueueZendeskVulnJobs queues the Zendesk vulnerability jobs to process asynchronously
|
|
// via the worker.
|
|
func QueueZendeskVulnJobs(
|
|
ctx context.Context,
|
|
ds fleet.Datastore,
|
|
logger *slog.Logger,
|
|
recentVulns []fleet.SoftwareVulnerability,
|
|
cveMeta map[string]fleet.CVEMeta,
|
|
) error {
|
|
logger.InfoContext(ctx, "zendesk integration enabled", "recent_vulns", len(recentVulns))
|
|
|
|
// for troubleshooting, log in debug level the CVEs that we will process
|
|
// (cannot be done in the loop below as we want to add the debug log
|
|
// _before_ we start processing them).
|
|
cves := make([]string, 0, len(recentVulns))
|
|
for _, vuln := range recentVulns {
|
|
cves = append(cves, vuln.GetCVE())
|
|
}
|
|
sort.Strings(cves)
|
|
logger.DebugContext(ctx, "recent CVEs to process", "recent_cves", fmt.Sprintf("%v", cves))
|
|
|
|
cveGrouped := make(map[string][]uint)
|
|
for _, v := range recentVulns {
|
|
cveGrouped[v.GetCVE()] = append(cveGrouped[v.GetCVE()], v.Affected())
|
|
}
|
|
|
|
for cve, sIDs := range cveGrouped {
|
|
args := vulnArgs{CVE: cve, AffectedSoftwareIDs: sIDs}
|
|
if meta, ok := cveMeta[cve]; ok {
|
|
args.EPSSProbability = meta.EPSSProbability
|
|
args.CVSSScore = meta.CVSSScore
|
|
args.CISAKnownExploit = meta.CISAKnownExploit
|
|
args.CVEPublished = meta.Published
|
|
}
|
|
job, err := QueueJob(ctx, ds, zendeskName, zendeskArgs{Vulnerability: &args})
|
|
if err != nil {
|
|
return ctxerr.Wrap(ctx, err, "queueing job")
|
|
}
|
|
logger.DebugContext(ctx, "queued zendesk vuln job", "job_id", job.ID)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// QueueZendeskFailingPolicyJob queues a Zendesk job for a failing policy to
|
|
// process asynchronously via the worker.
|
|
func QueueZendeskFailingPolicyJob(ctx context.Context, ds fleet.Datastore, logger *slog.Logger,
|
|
policy *fleet.Policy, hosts []fleet.PolicySetHost,
|
|
) error {
|
|
attrs := []interface{}{
|
|
"enabled", "true",
|
|
"failing_policy", policy.ID,
|
|
"hosts_count", len(hosts),
|
|
}
|
|
if policy.TeamID != nil {
|
|
attrs = append(attrs, "team_id", *policy.TeamID)
|
|
}
|
|
if len(hosts) == 0 {
|
|
logger.DebugContext(ctx, "skipping, no host", attrs...)
|
|
return nil
|
|
}
|
|
|
|
logger.InfoContext(ctx, "queueing Zendesk failing policy job", attrs...)
|
|
|
|
args := &failingPolicyArgs{
|
|
PolicyID: policy.ID,
|
|
PolicyName: policy.Name,
|
|
PolicyCritical: policy.Critical,
|
|
TeamID: policy.TeamID,
|
|
Hosts: hosts,
|
|
}
|
|
job, err := QueueJob(ctx, ds, zendeskName, zendeskArgs{FailingPolicy: args})
|
|
if err != nil {
|
|
return ctxerr.Wrap(ctx, err, "queueing job")
|
|
}
|
|
logger.DebugContext(ctx, "queued zendesk failing policy job", "job_id", job.ID)
|
|
return nil
|
|
}
|