mirror of
https://github.com/fleetdm/fleet
synced 2026-05-24 09:28:54 +00:00
Resolves #37192 Separating generic endpoint_utils middleware logic from domain-specific business logic. New bounded contexts would share the generic logic and implement their own domain-specific logic. The two approaches used in this PR are: - Use common `platform` types - Use interfaces In the next PR we will move `endpointer_utils`, `authzcheck` and `ratelimit` into `platform` directory. # Checklist for submitter - [x] Added changes file ## Testing - [x] Added/updated tests - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Restructured internal error handling and context management to support bounded context architecture. * Improved error context collection and telemetry observability through a provider-based mechanism. * Decoupled licensing and authentication concerns into interfaces for better modularity. * **Chores** * Updated internal package dependencies to align with new architectural boundaries. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
141 lines
4.6 KiB
Go
141 lines
4.6 KiB
Go
package auth
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"time"
|
|
|
|
kithttp "github.com/go-kit/kit/transport/http"
|
|
|
|
"github.com/fleetdm/fleet/v4/ee/server/service/hostidentity/httpsig"
|
|
"github.com/fleetdm/fleet/v4/server/contexts/authz"
|
|
"github.com/fleetdm/fleet/v4/server/contexts/ctxerr"
|
|
"github.com/fleetdm/fleet/v4/server/contexts/logging"
|
|
"github.com/fleetdm/fleet/v4/server/contexts/token"
|
|
"github.com/fleetdm/fleet/v4/server/contexts/viewer"
|
|
"github.com/fleetdm/fleet/v4/server/fleet"
|
|
"github.com/fleetdm/fleet/v4/server/service/middleware/log"
|
|
"github.com/go-kit/kit/endpoint"
|
|
)
|
|
|
|
// AuthViewer creates an authenticated viewer by validating the session key.
|
|
func AuthViewer(ctx context.Context, sessionKey string, svc fleet.Service) (*viewer.Viewer, error) {
|
|
session, err := svc.GetSessionByKey(ctx, sessionKey)
|
|
if err != nil {
|
|
return nil, fleet.NewAuthRequiredError(err.Error())
|
|
}
|
|
user, err := svc.UserUnauthorized(ctx, session.UserID)
|
|
if err != nil {
|
|
return nil, fleet.NewAuthRequiredError(err.Error())
|
|
}
|
|
return &viewer.Viewer{User: user, Session: session}, nil
|
|
}
|
|
|
|
// AuthenticatedUser wraps an endpoint, requires that the Fleet user is
|
|
// authenticated, and populates the context with a Viewer struct for that user.
|
|
//
|
|
// If auth fails or the user must reset their password, an error is returned.
|
|
func AuthenticatedUser(svc fleet.Service, next endpoint.Endpoint) endpoint.Endpoint {
|
|
authUserFunc := func(ctx context.Context, request interface{}) (interface{}, error) {
|
|
// first check if already successfully set
|
|
if v, ok := viewer.FromContext(ctx); ok {
|
|
if v.User.IsAdminForcedPasswordReset() {
|
|
return nil, fleet.ErrPasswordResetRequired
|
|
}
|
|
|
|
return next(ctx, request)
|
|
}
|
|
|
|
requestPath, _ := ctx.Value(kithttp.ContextKeyRequestPath).(string)
|
|
|
|
httpSig, sigOk := httpsig.FromContext(ctx)
|
|
if sigOk && httpsig.IsSigAuthEndpoint(requestPath) {
|
|
if time.Now().After(httpSig.NotValidAfter) {
|
|
return nil, fleet.NewAuthFailedError("host identity certificate expired")
|
|
}
|
|
if httpSig.HostID == nil {
|
|
return nil, fleet.NewAuthFailedError("identity certificate is not linked to a specific host")
|
|
}
|
|
if ac, ok := authz.FromContext(ctx); ok {
|
|
ac.SetAuthnMethod(authz.AuthnHTTPMessageSignature)
|
|
}
|
|
return next(ctx, request)
|
|
}
|
|
|
|
// if not successful, try again this time with errors
|
|
sessionKey, ok := token.FromContext(ctx)
|
|
if !ok {
|
|
return nil, fleet.NewAuthHeaderRequiredError("no auth token")
|
|
}
|
|
|
|
v, err := AuthViewer(ctx, string(sessionKey), svc)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if v.User.IsAdminForcedPasswordReset() {
|
|
return nil, fleet.ErrPasswordResetRequired
|
|
}
|
|
|
|
ctx = viewer.NewContext(ctx, *v)
|
|
// Register viewer as error context provider for ctxerr enrichment
|
|
ctx = ctxerr.AddErrorContextProvider(ctx, v)
|
|
// Register viewer as user emailer for logging
|
|
ctx = logging.WithUserEmailer(ctx, v)
|
|
if ac, ok := authz.FromContext(ctx); ok {
|
|
ac.SetAuthnMethod(authz.AuthnUserToken)
|
|
}
|
|
return next(ctx, request)
|
|
}
|
|
|
|
return log.Logged(authUserFunc)
|
|
}
|
|
|
|
func UnauthenticatedRequest(_ fleet.Service, next endpoint.Endpoint) endpoint.Endpoint {
|
|
return log.Logged(next)
|
|
}
|
|
|
|
// errorHandler has the same signature as http.Error
|
|
type errorHandler func(w http.ResponseWriter, detail string, status int)
|
|
|
|
func AuthenticatedUserMiddleware(svc fleet.Service, errHandler errorHandler, next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
// first check if already successfully set
|
|
if v, ok := viewer.FromContext(r.Context()); ok {
|
|
if v.User.IsAdminForcedPasswordReset() {
|
|
errHandler(w, fleet.ErrPasswordResetRequired.Error(), http.StatusUnauthorized)
|
|
return
|
|
}
|
|
next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
// if not successful, try again this time with errors
|
|
sessionKey, ok := token.FromContext(r.Context())
|
|
if !ok {
|
|
errHandler(w, fleet.NewAuthHeaderRequiredError("no auth token").Error(), http.StatusUnauthorized)
|
|
return
|
|
}
|
|
|
|
v, err := AuthViewer(r.Context(), string(sessionKey), svc)
|
|
if err != nil {
|
|
errHandler(w, err.Error(), http.StatusUnauthorized)
|
|
return
|
|
}
|
|
|
|
if v.User.IsAdminForcedPasswordReset() {
|
|
errHandler(w, fleet.ErrPasswordResetRequired.Error(), http.StatusUnauthorized)
|
|
return
|
|
}
|
|
|
|
ctx := viewer.NewContext(r.Context(), *v)
|
|
// Register viewer as error context provider for ctxerr enrichment
|
|
ctx = ctxerr.AddErrorContextProvider(ctx, v)
|
|
// Register viewer as user emailer for logging
|
|
ctx = logging.WithUserEmailer(ctx, v)
|
|
if ac, ok := authz.FromContext(r.Context()); ok {
|
|
ac.SetAuthnMethod(authz.AuthnUserToken)
|
|
}
|
|
next.ServeHTTP(w, r.WithContext(ctx))
|
|
})
|
|
}
|