mirror of
https://github.com/fleetdm/fleet
synced 2026-05-24 09:28:54 +00:00
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #40540 Almost done with slog migration. # Checklist for submitter - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - Changes present in previous PR ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated internal logging infrastructure to use Go's standard logging library, modernizing the logging system while maintaining existing functionality and error handling behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
144 lines
3.7 KiB
Go
144 lines
3.7 KiB
Go
package mysql
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"log/slog"
|
|
"sync"
|
|
"sync/atomic"
|
|
"testing"
|
|
|
|
"github.com/DATA-DOG/go-sqlmock"
|
|
gmysql "github.com/go-sql-driver/mysql"
|
|
"github.com/jmoiron/sqlx"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// readOnlyErr returns a MySQL error that simulates a read-only database (error 1792).
|
|
func readOnlyErr() error {
|
|
return &gmysql.MySQLError{Number: 1792, Message: "Cannot execute statement in a READ ONLY transaction."}
|
|
}
|
|
|
|
func TestTriggerFatalErrorCallsHandler(t *testing.T) {
|
|
var called atomic.Bool
|
|
var capturedErr atomic.Value
|
|
SetFatalErrorHandler(func(_ context.Context, err error) {
|
|
called.Store(true)
|
|
capturedErr.Store(err)
|
|
})
|
|
t.Cleanup(func() { SetFatalErrorHandler(nil) })
|
|
|
|
testErr := errors.New("test read-only error")
|
|
TriggerFatalError(t.Context(), testErr)
|
|
|
|
assert.True(t, called.Load())
|
|
assert.Equal(t, testErr, capturedErr.Load())
|
|
}
|
|
|
|
func TestTriggerFatalErrorPanicsWithoutHandler(t *testing.T) {
|
|
SetFatalErrorHandler(nil)
|
|
|
|
assert.Panics(t, func() {
|
|
TriggerFatalError(t.Context(), errors.New("read-only"))
|
|
})
|
|
}
|
|
|
|
func TestTriggerFatalErrorFiresOnce(t *testing.T) {
|
|
var callCount atomic.Int32
|
|
SetFatalErrorHandler(func(_ context.Context, _ error) {
|
|
callCount.Add(1)
|
|
})
|
|
t.Cleanup(func() { SetFatalErrorHandler(nil) })
|
|
|
|
var wg sync.WaitGroup
|
|
for range 100 {
|
|
wg.Go(func() {
|
|
TriggerFatalError(t.Context(), errors.New("read-only"))
|
|
})
|
|
}
|
|
wg.Wait()
|
|
|
|
assert.Equal(t, int32(1), callCount.Load())
|
|
}
|
|
|
|
func TestTransactionReadOnlyTriggersFatalError(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
txFunc func(ctx *testing.T, db *sqlx.DB, mock sqlmock.Sqlmock) error
|
|
setupMock func(mock sqlmock.Sqlmock)
|
|
}{
|
|
{
|
|
name: "WithRetryTxx read-only from fn",
|
|
setupMock: func(mock sqlmock.Sqlmock) {
|
|
mock.ExpectBegin()
|
|
mock.ExpectRollback()
|
|
},
|
|
txFunc: func(ctx *testing.T, db *sqlx.DB, mock sqlmock.Sqlmock) error {
|
|
return WithRetryTxx(ctx.Context(), db, func(tx sqlx.ExtContext) error {
|
|
return readOnlyErr()
|
|
}, slog.New(slog.DiscardHandler))
|
|
},
|
|
},
|
|
{
|
|
name: "WithRetryTxx read-only from commit",
|
|
setupMock: func(mock sqlmock.Sqlmock) {
|
|
mock.ExpectBegin()
|
|
mock.ExpectCommit().WillReturnError(readOnlyErr())
|
|
},
|
|
txFunc: func(ctx *testing.T, db *sqlx.DB, mock sqlmock.Sqlmock) error {
|
|
return WithRetryTxx(ctx.Context(), db, func(tx sqlx.ExtContext) error {
|
|
return nil
|
|
}, slog.New(slog.DiscardHandler))
|
|
},
|
|
},
|
|
{
|
|
name: "WithTxx read-only from fn",
|
|
setupMock: func(mock sqlmock.Sqlmock) {
|
|
mock.ExpectBegin()
|
|
mock.ExpectRollback()
|
|
},
|
|
txFunc: func(ctx *testing.T, db *sqlx.DB, mock sqlmock.Sqlmock) error {
|
|
return WithTxx(ctx.Context(), db, func(tx sqlx.ExtContext) error {
|
|
return readOnlyErr()
|
|
}, slog.New(slog.DiscardHandler))
|
|
},
|
|
},
|
|
{
|
|
name: "WithTxx read-only from commit",
|
|
setupMock: func(mock sqlmock.Sqlmock) {
|
|
mock.ExpectBegin()
|
|
mock.ExpectCommit().WillReturnError(readOnlyErr())
|
|
},
|
|
txFunc: func(ctx *testing.T, db *sqlx.DB, mock sqlmock.Sqlmock) error {
|
|
return WithTxx(ctx.Context(), db, func(tx sqlx.ExtContext) error {
|
|
return nil
|
|
}, slog.New(slog.DiscardHandler))
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
var handlerCalled atomic.Bool
|
|
SetFatalErrorHandler(func(_ context.Context, _ error) {
|
|
handlerCalled.Store(true)
|
|
})
|
|
t.Cleanup(func() { SetFatalErrorHandler(nil) })
|
|
|
|
db, mock, err := sqlmock.New()
|
|
require.NoError(t, err)
|
|
defer db.Close()
|
|
sqlxDB := sqlx.NewDb(db, "sqlmock")
|
|
|
|
tc.setupMock(mock)
|
|
|
|
err = tc.txFunc(t, sqlxDB, mock)
|
|
|
|
require.Error(t, err)
|
|
assert.True(t, IsReadOnlyError(err))
|
|
assert.True(t, handlerCalled.Load())
|
|
require.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
}
|
|
}
|