mirror of
https://github.com/fleetdm/fleet
synced 2026-05-24 09:28:54 +00:00
34d0620f80
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #42898 I was waiting for my [upstream PR](https://github.com/micromdm/nanomdm/pull/250) to be merged, but I've waited for 2+ weeks now, so I'll go ahead and do the same change here, and then if the maintainer requests change I can update this fix retrospectively # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. **None, since it's unused in our codebase at this point** - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. - [x] Timeouts are implemented and retries are limited to avoid infinite loops - [x] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes ## Testing - [x] Added/updated automated tests - [ ] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Prevented nil push entries from causing panics during concurrent push processing * Adjusted worker allocation so concurrency scales down when batch sizes are smaller * Clamped configured worker count to a minimum of 1 (documented default behavior) * **Tests** * Added regression test ensuring safe handling of nil entries in concurrent push inputs and updated test harness to exercise reduced-worker scenarios <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .. | ||
| buford | ||
| nanopush | ||
| service | ||
| push.go | ||