mirror of
https://github.com/fleetdm/fleet
synced 2026-05-24 09:28:54 +00:00
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #42184 # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. - [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes ## Testing - [ ] Added/updated automated tests - [ ] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [ ] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [ ] Confirmed that the fix is not expected to adversely impact load test results - [ ] Alerted the release DRI if additional load testing is needed ## Database migrations - [ ] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [ ] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [ ] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). ## New Fleet configuration settings - [ ] Setting(s) is/are explicitly excluded from GitOps If you didn't check the box above, follow this checklist for GitOps-enabled settings: - [ ] Verified that the setting is exported via `fleetctl generate-gitops` - [ ] Verified the setting is documented in a separate PR to [the GitOps documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485) - [ ] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional) - [ ] Verified that any relevant UI is disabled when GitOps mode is enabled ## fleetd/orbit/Fleet Desktop - [ ] Verified compatibility with the latest released version of Fleet (see [Must rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/workflows/fleetd-development-and-release-strategy.md)) - [ ] If the change applies to only one platform, confirmed that `runtime.GOOS` is used as needed to isolate changes - [ ] Verified that fleetd runs on macOS, Linux and Windows - [ ] Verified auto-update works from the released version of component to the new version (see [tools/tuf/test](../tools/tuf/test/README.md)) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **New Features** * Added support for GitOps exceptions per entity type (labels, software, secrets), allowing specific areas to bypass GitOps mode restrictions when configured. * **Bug Fixes** * Improved GitOps mode behavior to properly respect per-entity-type exception settings across software, labels, and secrets management. * **Tests** * Extended test coverage for GitOps exception handling scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
87 lines
2.5 KiB
TypeScript
87 lines
2.5 KiB
TypeScript
import React, { useCallback, useContext, useState } from "react";
|
|
|
|
import teamPoliciesAPI from "services/entities/team_policies";
|
|
import { NotificationContext } from "context/notification";
|
|
|
|
import { getErrorReason } from "interfaces/errors";
|
|
|
|
import Modal from "components/Modal";
|
|
import Button from "components/buttons/Button";
|
|
import GitOpsModeTooltipWrapper from "components/GitOpsModeTooltipWrapper";
|
|
|
|
const baseClass = "add-patch-policy-modal";
|
|
|
|
const EXISTING_PATCH_POLICY_ERROR_MSG = `Couldn't add patch policy. Specified "patch_software_title_id" already has a policy with "type" set to "patch".`;
|
|
|
|
interface IAddPatchPolicyModal {
|
|
softwareId: number;
|
|
teamId: number;
|
|
onExit: () => void;
|
|
onSuccess: () => void;
|
|
}
|
|
|
|
const AddPatchPolicyModal = ({
|
|
softwareId,
|
|
teamId,
|
|
onExit,
|
|
onSuccess,
|
|
}: IAddPatchPolicyModal) => {
|
|
const { renderFlash } = useContext(NotificationContext);
|
|
const [isAddingPatchPolicy, setIsAddingPatchPolicy] = useState(false);
|
|
|
|
const onAddPatchPolicy = useCallback(async () => {
|
|
setIsAddingPatchPolicy(true);
|
|
try {
|
|
await teamPoliciesAPI.create({
|
|
type: "patch",
|
|
patch_software_title_id: softwareId,
|
|
team_id: teamId,
|
|
});
|
|
renderFlash("success", "Successfully added patch policy.");
|
|
onSuccess();
|
|
} catch (error) {
|
|
const reason = getErrorReason(error);
|
|
if (reason.includes("already has a policy")) {
|
|
renderFlash("error", EXISTING_PATCH_POLICY_ERROR_MSG);
|
|
}
|
|
renderFlash("error", "Couldn't add patch policy. Please try again.");
|
|
}
|
|
setIsAddingPatchPolicy(false);
|
|
onExit();
|
|
}, [softwareId, teamId, renderFlash, onSuccess, onExit]);
|
|
|
|
return (
|
|
<Modal
|
|
className={baseClass}
|
|
title="Add patch policy"
|
|
onExit={onExit}
|
|
isContentDisabled={isAddingPatchPolicy}
|
|
>
|
|
<>
|
|
<p>
|
|
This creates a read-only policy. Later, to enforce remediation, head
|
|
to this policy's page.
|
|
</p>
|
|
<div className="modal-cta-wrap">
|
|
<GitOpsModeTooltipWrapper
|
|
entityType="software"
|
|
renderChildren={(disableChildren) => (
|
|
<Button
|
|
onClick={onAddPatchPolicy}
|
|
isLoading={isAddingPatchPolicy}
|
|
disabled={disableChildren}
|
|
>
|
|
Add
|
|
</Button>
|
|
)}
|
|
/>
|
|
<Button variant="inverse" onClick={onExit}>
|
|
Cancel
|
|
</Button>
|
|
</div>
|
|
</>
|
|
</Modal>
|
|
);
|
|
};
|
|
|
|
export default AddPatchPolicyModal;
|