mirror of
https://github.com/fleetdm/fleet
synced 2026-05-24 09:28:54 +00:00
0873c50a30
This pull request enhances the safety of the `linux_wipe.sh` script by ensuring that destructive file operations do not affect network-mounted filesystems. The changes introduce checks to detect network filesystems, prevent accidental deletion of remote data, and improve the reliability of wipe operations by avoiding crossing filesystem boundaries. **Network filesystem safety improvements:** * Added a `NETWORK_FS_TYPES` variable and functions to detect and unmount network filesystems, preventing the script from deleting data on NFS, CIFS, SMB, SSHFS, and similar mounts. (`ee/server/service/embedded_scripts/linux_wipe.sh`) [[1]](diffhunk://#diff-7ac85220cbd45e63481837a405dacf198822a4fbf885b88f89b9bc870c947fccR3-R4) [[2]](diffhunk://#diff-7ac85220cbd45e63481837a405dacf198822a4fbf885b88f89b9bc870c947fccR17-R84) * Introduced an `unmount_network_filesystems` function called before wiping operations to unmount all detected network filesystems. (`ee/server/service/embedded_scripts/linux_wipe.sh`) * Added an `is_network_mount` function to skip wiping any path residing on a network filesystem. (`ee/server/service/embedded_scripts/linux_wipe.sh`) **Safe file deletion enhancements:** * Implemented a `safe_rm` function that ensures file deletions do not cross filesystem boundaries, using `rm --one-file-system` or `find -xdev` as a fallback. All destructive operations now use this wrapper. (`ee/server/service/embedded_scripts/linux_wipe.sh`) * Updated `wipe_non_essential_data` and `wipe_system_files` to use `safe_rm` and to skip paths on network filesystems. (`ee/server/service/embedded_scripts/linux_wipe.sh`) These changes significantly reduce the risk of deleting data on remote or shared filesystems during a wipe operation. <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves # # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects - [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes ## Testing - [ ] Added/updated automated tests - [ ] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [ ] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [ ] Confirmed that the fix is not expected to adversely impact load test results - [ ] Alerted the release DRI if additional load testing is needed ## Database migrations - [ ] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [ ] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [ ] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). ## New Fleet configuration settings - [ ] Setting(s) is/are explicitly excluded from GitOps If you didn't check the box above, follow this checklist for GitOps-enabled settings: - [ ] Verified that the setting is exported via `fleetctl generate-gitops` - [ ] Verified the setting is documented in a separate PR to [the GitOps documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485) - [ ] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional) - [ ] Verified that any relevant UI is disabled when GitOps mode is enabled ## fleetd/orbit/Fleet Desktop - [ ] Verified compatibility with the latest released version of Fleet (see [Must rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/workflows/fleetd-development-and-release-strategy.md)) - [ ] If the change applies to only one platform, confirmed that `runtime.GOOS` is used as needed to isolate changes - [ ] Verified that fleetd runs on macOS, Linux and Windows - [ ] Verified auto-update works from the released version of component to the new version (see [tools/tuf/test](../tools/tuf/test/README.md)) --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| linux_lock.sh | ||
| linux_unlock.sh | ||
| linux_wipe.sh | ||
| windows_lock.ps1 | ||
| windows_unlock.ps1 | ||