mirror of
https://github.com/fleetdm/fleet
synced 2026-05-06 06:48:54 +00:00
12f2ee6ad1
#31592 There's still some QA to be done for edge cases and re-connects, but this is ready for review. <img width="341" height="103" alt="Screenshot 2025-08-07 at 11 19 33 AM" src="https://github.com/user-attachments/assets/01e48ca2-8ab1-412c-be01-8e806a5a8b1c" /> Changes: - To improve UX I'm now using `HEAD /api/fleet/device/ping` API every 10 seconds for connectivity/offline check (instead of the expensive DesktopSummary one every 5 minutes). This is to address feedback from a customer: > "If the internet is not connected and we reconnect with an ethernet connection for example, it would be good to try to see if we can refresh it text from the offline indicator given that's not the case anymore. - It might take up to 1m for Fleet Desktop to show the offline indicator (we check every 10s with ping and now we are adding 6 more requests in 1 minute to make sure just one bad request doesn't unnecessarily display the offline indicator). - Requests without proper public IP were being incorrectly rate limited (all under the same bucket). So we will now not make these requests and instead log a WARNING. This is a-ok as the recommended approach to deploy Fleet is with a TLS terminator that will add the public IP of the request before sending it to Fleet. --- - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [X] Added/updated automated tests - [ ] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [ ] QA'd all new/changed functionality manually ## fleetd/orbit/Fleet Desktop - [ ] Verified compatibility with the latest released version of Fleet (see [Must rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/workflows/fleetd-development-and-release-strategy.md)) - [ ] Verified that fleetd runs on macOS, Linux and Windows - [ ] Verified auto-update works from the released version of component to the new version (see [tools/tuf/test](../tools/tuf/test/README.md)) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved accuracy in identifying client public IP addresses, reducing incorrect rate limiting for Fleet Desktop users. * Offline indicator is now less sensitive to brief network interruptions, reducing false offline signals and allowing faster recovery when connectivity is restored. * Updated offline message for clearer status communication. * **New Features** * Enhanced error messages and logging for rate limiting events, providing clearer feedback when limits are reached. * **Tests** * Expanded test coverage for rate limiting, including scenarios with missing public IPs and improved assertions for error handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .. | ||
| .keep | ||
| 28133-require-bitlocker-pin | ||
| 29793-launch-processes-using-correct-context | ||
| 30955-fixed-bug-with-about-fleet | ||
| 31269-debian-noninteractive-software-installs | ||
| 31338-31525-tarball-install | ||
| 31372-host-identity-cert-renewal | ||
| 31387-fleetdesktop-mdm-migrate | ||
| 31592-improve-offline-indicator | ||
| fleetd-extensions-support-arm64 | ||
| fleetd-tpm-key | ||
| update-go-1.24.5 | ||