mirror of
https://github.com/fleetdm/fleet
synced 2026-05-24 09:28:54 +00:00
For #25479 # Checklist for submitter - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Manual QA for all new/changed functionality ## Details This PR fixes the `privacy_preferences` table results generator for the Chrome Extension. The root cause was that we were attempting to return boolean values directly to sqlite, which doesn't have a native boolean type. The fix is to coerce booleans to "1" or "0" as we do for other tables in the extension. The _proximate_ cause of the issue was that the warnings generated at the db level (in this case about not being able to handle the `null` values that sqlite was coercing booleans to) are not being handled correctly. I'll tackle this in a separate PR as it's a little more complicated to debug and fix. ## Testing On a Chromebook, was able to run a live `select * from privacy_preferences` query with results: <img width="1706" alt="image" src="https://github.com/user-attachments/assets/7dcc4410-70fd-4381-842d-fd06d43b94ae" /> <img width="1708" alt="image" src="https://github.com/user-attachments/assets/db783e7b-3351-424c-82e3-b7e80c1d999d" /> Added automated test that fails on main and passes on this branch. |
||
|---|---|---|
| .. | ||
| .keep | ||
| 25479-fix-privacy-preferences-table | ||