mirror of
https://github.com/fleetdm/fleet
synced 2026-05-06 14:58:33 +00:00
0aece4fea4
This pull request simplifies and improves the automation for updating Safari version policies on macOS by switching from a multi-line YAML query to a single-line query and streamlining the associated update script. The changes make the update process more robust, easier to maintain, and less error-prone, especially when parsing and updating the policy file. **Policy and script simplification:** * Converted the `query` field in `update-safari.yml` from a multi-line YAML block to a single-line statement, reducing complexity and making it easier to update programmatically. **Script robustness and maintainability:** * Updated `.github/scripts/dogfood-policy-updater-latest-safari.sh` to extract and update the single-line `query` instead of handling a multi-line block, greatly simplifying the parsing and replacement logic. [[1]](diffhunk://#diff-87712030515d50f6a970f044127d52639dac98021cf573f214f8f36cb1273c17L26-R37) [[2]](diffhunk://#diff-87712030515d50f6a970f044127d52639dac98021cf573f214f8f36cb1273c17L97-R123) * Improved error handling for environment variables, requiring only the essential `DOGFOOD_AUTOMATION_TOKEN` to be set, and clarified error messages. * Enhanced validation of the Safari feed response by checking for valid JSON and explicit API errors using `jq`, making the update process more reliable. * Changed the update workflow to write changes directly to the file and rely on GitHub Actions to create pull requests, removing the script's own git and PR logic for a cleaner CI/CD process. |
||
|---|---|---|
| .. | ||
| check-infra-dependencies.sh | ||
| detect-new-fmas-in-pr.sh | ||
| dogfood-policy-updater-latest-1password-macos.sh | ||
| dogfood-policy-updater-latest-macos.sh | ||
| dogfood-policy-updater-latest-safari.sh | ||
| dogfood-update-testing-qa-apps.sh | ||
| filter-apps-json.sh | ||
| helm-check-expected.sh | ||
| rclone-install.sh | ||
| update_osquery_versions.py | ||