mirror of
https://github.com/fleetdm/fleet
synced 2026-05-10 18:51:03 +00:00
## Addresses #15325 - Define shared global styles for forms (`form` and `.form`s) and `.form-field`s - Sweep through the app, updating each form from being locally styled to first prioritizing the global styles and only defining local styles where needed for custom behavior - Remove lots of unnecessary nesting of elements - Other small bug fixes and improvements ### Samples, before (L) | after (R): **Save query modal**  **Edit query form**  **Add hosts modal**  ## QA Plan: @xpkoala here's the same list from the issue, freshly de-checked for you to use if it's helpful: * Please check error states of each field #### Specified by issue: ##### In "Save query" modal: - [ ] Reduce space between checkboxes and their help text to 8px/0.5rem for the following fields: - [ ] Observers can run - [ ] Discard data - [ ] Update the following checkbox labels to have normal font weight (not bold): - [ ] Discard data ##### On "Edit query" page: - [ ] Update the following checkbox labels to have normal font weight (not bold): - [ ] Observers can run - [ ] Discard data ##### In "Add hosts" modal, for copy text fields: - [ ] match typical form form field styles - [ ] Adjust the positioning of the copy icon to keep it from being too far down ##### Further locations to check - [ ] ChangeEmailForm.jsx - [ ] ChangePasswordForm.jsx - [ ] ConfirmInviteForm.jsx - [ ] ConfirmSSOInviteForm.jsx - [ ] EnrollSecretModal.tsx - [ ] ForgotPasswordForm.jsx - [ ] LoginForm.tsx - [ ] EditPackForm.tsx - [ ] (New)PackForm.tsx - [ ] AdminDetails.jsx - [ ] ConfirmationPage.tsx - [ ] FleetDetails.jsx - [ ] OrgDetails.jsx - [ ] ResetPasswordForm.tsx - [ ] UserSettingsForm.jsx - [ ] EditTeamModal.tsx - [ ] IdpSection.tsx - [ ] DeleteIntegrationModal.tsx - [ ] IntegrationForm.tsx - [ ] EndUserMigrationSection.tsx - [ ] RequestCSRModal.tsx - [ ] Advanced.tsx - [ ] Agents.tsx - [ ] FleetDesktop.tsx - [ ] HostStatusWebhook.tsx front - [ ] Info.tsx - [ ] Smtp.tsx - [ ] Sso.tsx - [ ] Statistics.tsx - [ ] WebAddress.tsx - [ ] CreateTeamModal.tsx - [ ] DeleteTeamModal.tsx - [ ] EditTeamModal.tsx - [ ] AgentOptionsPage.tsx - updated the layout of this page to align with the rest of the forms in the UI – can easily revert if it's not what we want - [ ] AddMemberModal.tsx - [ ] RemoveMemberModal.tsx - [ ] UserForm.tsx - Used by both `EditUserModal` and `CreateUserModal` - A few different conditions that cause different rendering behavior - [ ] DeleteHostModal.tsx - [ ] TransferHostModal.tsx - [ ] LabelForm.tsx - [ ] MacOSTargetForm.tsx - [ ] WindowsTargetForm.tsx - [ ] BootstrapPackageListltem.ts - [ ] EndUserAuthForm.tsx - [ ] PackQueryEditorModal.tsx - [ ] PolicyForm.tsx - [ ] SaveNewPolicyModal.tsx - [ ] ConfirmSaveChangesModal.tsx - [ ] Query automations modal - [ ] Policy automations modal - addresses #16010 - [ ] SoftwareAutomationsModal ## Checklist for submitter - [x] Changes file added for user-visible changes in `changes/` - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com> Co-authored-by: RachelElysia <71795832+RachelElysia@users.noreply.github.com>
131 lines
2.5 KiB
SCSS
131 lines
2.5 KiB
SCSS
.input-icon-field {
|
|
position: relative;
|
|
|
|
&__icon {
|
|
position: absolute;
|
|
right: 6px;
|
|
top: 28px;
|
|
color: $core-fleet-blue;
|
|
|
|
&--active {
|
|
color: $core-vibrant-blue;
|
|
}
|
|
|
|
&--error {
|
|
border: 1px solid $core-vibrant-red;
|
|
box-sizing: border-box;
|
|
border-radius: 4px;
|
|
}
|
|
}
|
|
|
|
// Refactor to include svg icons
|
|
&--icon-start {
|
|
margin-top: 0;
|
|
|
|
.input-icon-field__icon {
|
|
position: absolute;
|
|
left: 12px;
|
|
top: 13px;
|
|
width: 16px;
|
|
font-size: $x-small;
|
|
color: $core-fleet-blue;
|
|
z-index: 1;
|
|
}
|
|
}
|
|
|
|
&__input {
|
|
border: 1px solid $ui-fleet-black-10;
|
|
background-color: $ui-light-grey;
|
|
border-radius: $border-radius;
|
|
padding: 9px 30px 9px $pad-medium;
|
|
font-size: $x-small;
|
|
text-indent: 1px;
|
|
position: relative;
|
|
width: 100%;
|
|
box-sizing: border-box;
|
|
color: $core-fleet-black;
|
|
font-weight: $regular;
|
|
transition: border-color 100ms;
|
|
|
|
::placeholder {
|
|
color: $core-fleet-blue;
|
|
}
|
|
|
|
&:hover,
|
|
&:focus {
|
|
border: 1px solid $core-vibrant-blue;
|
|
|
|
// Icon color matches border color on focus and on hover
|
|
+ .input-icon-field__icon {
|
|
svg {
|
|
path {
|
|
fill: $core-vibrant-blue;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
&:focus {
|
|
outline: none;
|
|
}
|
|
|
|
&:disabled {
|
|
color: $ui-fleet-black-50;
|
|
cursor: not-allowed;
|
|
}
|
|
|
|
&--error {
|
|
color: $core-vibrant-red;
|
|
border: 1px solid $core-vibrant-red;
|
|
box-sizing: border-box;
|
|
border-radius: 4px;
|
|
}
|
|
}
|
|
|
|
&__label {
|
|
display: block;
|
|
font-size: $x-small;
|
|
font-weight: $bold;
|
|
|
|
&[data-has-tooltip="true"] {
|
|
margin-bottom: $pad-small;
|
|
}
|
|
}
|
|
|
|
&__errors {
|
|
color: $core-vibrant-red;
|
|
}
|
|
|
|
// overwrite icon position and input padding
|
|
&--icon-start {
|
|
input {
|
|
padding: 9.5px 12px 9.5px 36px; // New figma styling
|
|
}
|
|
.fleeticon {
|
|
right: auto;
|
|
left: 16px;
|
|
top: 36px;
|
|
font-weight: 700;
|
|
}
|
|
}
|
|
|
|
/* removes the 'X' from IE input type=search */
|
|
input[type="search"]::-ms-clear {
|
|
display: none;
|
|
width: 0;
|
|
height: 0;
|
|
}
|
|
input[type="search"]::-ms-reveal {
|
|
display: none;
|
|
width: 0;
|
|
height: 0;
|
|
}
|
|
|
|
/* removes the 'X' from Chrome input type=search */
|
|
input[type="search"]::-webkit-search-decoration,
|
|
input[type="search"]::-webkit-search-cancel-button,
|
|
input[type="search"]::-webkit-search-results-button,
|
|
input[type="search"]::-webkit-search-results-decoration {
|
|
display: none;
|
|
}
|
|
}
|