mirror of
https://github.com/fleetdm/fleet
synced 2026-05-23 08:58:41 +00:00
d66b259306
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #37710 Adds some logic to try to use the name/version/identifier from a bundle that exactly matches the bundle identifier from the root pkg-info element, if found. The loop continues even if that is found since packageIDSet needs to be built. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes ## Testing - [ ] Added/updated automated tests - [ ] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [x] QA'd all new/changed functionality manually Tested against all installers from the google drive folder, prisma access browser is the only package with changed metadata. Before: ``` File: Prisma Access Browser-144.6.10.59-b070a3e0.pkg - Name: 'PrismaAccessBrowserSoftwareUpdateAgent' - Bundle Identifier: 'com.paloaltonetworks.PrismaAccessBrowserUpdater.Agent' - Package IDs: 'com.paloaltonetworks.PrismaAccessBrowserUpdater,com.paloaltonetworks.PrismaAccessBrowserUpdater.Agent,com.talon-sec.Work,com.talon-sec.Work.framework,com.talon-sec.Work.framework.AlertNotificationService,com.talon-sec.Work.helper,com.talon-sec.Work.helper.plugin,com.talon-sec.Work.helper.renderer,org.sparkle-project.Downloader,org.sparkle-project.InstallerLauncher,org.sparkle-project.Sparkle,org.sparkle-project.Sparkle.Updater' - Version: 144.6.10 ``` After: ``` File: Prisma Access Browser-144.6.10.59-b070a3e0.pkg - Name: 'Prisma Access Browser' - Bundle Identifier: 'com.talon-sec.Work' - Package IDs: 'com.paloaltonetworks.PrismaAccessBrowserUpdater,com.paloaltonetworks.PrismaAccessBrowserUpdater.Agent,com.talon-sec.Work,com.talon-sec.Work.framework,com.talon-sec.Work.framework.AlertNotificationService,com.talon-sec.Work.helper,com.talon-sec.Work.helper.plugin,com.talon-sec.Work.helper.renderer,org.sparkle-project.Downloader,org.sparkle-project.InstallerLauncher,org.sparkle-project.Sparkle,org.sparkle-project.Sparkle.Updater' - Version: 144.6.10.59 ```
1 line
79 B
Text
1 line
79 B
Text
* Added logic to .pkg metadata extraction to match the root bundle identifier.
|