fleet/pkg/fleethttp/fleethttp_test.go
Victor Lyuboslavsky 2eeb11dc6a
Added OTEL instrumentation to Fleet's internal HTTP client. (#40568)
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #40564

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.

## Testing

- [x] QA'd all new/changed functionality manually


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Added OpenTelemetry instrumentation to the internal HTTP client to
provide enhanced observability through distributed tracing and metrics
collection for HTTP operations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-02-26 12:49:52 -06:00

132 lines
3.5 KiB
Go

package fleethttp
import (
"crypto/tls"
"net/http"
"reflect"
"testing"
"time"
"unsafe"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
)
func TestClient(t *testing.T) {
cases := []struct {
name string
opts []ClientOpt
defaultInner bool
nilRedirect bool
timeout time.Duration
}{
{"default", nil, true, true, 0},
{"timeout", []ClientOpt{WithTimeout(time.Second)}, true, true, time.Second},
{"nofollow", []ClientOpt{WithFollowRedir(false)}, true, false, 0},
{"tlsconfig", []ClientOpt{WithTLSClientConfig(&tls.Config{})}, false, true, 0},
{"combined", []ClientOpt{
WithTLSClientConfig(&tls.Config{}),
WithTimeout(time.Second),
WithFollowRedir(false),
}, false, false, time.Second},
}
for _, c := range cases {
t.Run(c.name, func(t *testing.T) {
cli := NewClient(c.opts...)
require.IsType(t, &otelhttp.Transport{}, cli.Transport, "outer transport should be otelhttp")
// Inspect the inner (base) transport wrapped by otelhttp via unsafe since the rt field is unexported.
rtField := reflect.ValueOf(cli.Transport).Elem().FieldByName("rt")
inner := *(*http.RoundTripper)(unsafe.Pointer(rtField.UnsafeAddr())) //nolint:gosec
if c.defaultInner {
assert.Equal(t, http.DefaultTransport, inner, "inner transport should be http.DefaultTransport")
} else {
assert.IsType(t, &http.Transport{}, inner, "inner transport should be a custom *http.Transport") //nolint:gocritic
}
if c.nilRedirect {
assert.Nil(t, cli.CheckRedirect)
} else {
assert.NotNil(t, cli.CheckRedirect)
}
assert.Equal(t, c.timeout, cli.Timeout)
})
}
}
func TestTransport(t *testing.T) {
defaultTLSConf := http.DefaultTransport.(*http.Transport).TLSClientConfig
cases := []struct {
name string
opts []TransportOpt
defaultTLS bool
}{
{"default", nil, true},
{"tlsconf", []TransportOpt{WithTLSConfig(&tls.Config{})}, false},
}
for _, c := range cases {
t.Run(c.name, func(t *testing.T) {
tr := NewTransport(c.opts...)
if c.defaultTLS {
assert.Equal(t, defaultTLSConf, tr.TLSClientConfig)
} else {
assert.NotEqual(t, defaultTLSConf, tr.TLSClientConfig)
}
assert.NotNil(t, tr.Proxy)
assert.NotNil(t, tr.DialContext)
})
}
}
func TestHostnamesMatch(t *testing.T) {
tests := []struct {
name string
inputA string
inputB string
expectedMatch bool
expectError bool
}{
{
name: "ValidHostnamesMatch",
inputA: "https://www.example.com/path",
inputB: "http://www.example.com:80",
expectedMatch: true,
expectError: false,
},
{
name: "ValidHostnamesDoNotMatch",
inputA: "https://www.example.com",
inputB: "https://sub.example.com",
expectedMatch: false,
expectError: false,
},
{
name: "InvalidURLA",
inputA: "ht tp://foo.com",
inputB: "https://www.example.com",
expectedMatch: false,
expectError: true,
},
{
name: "InvalidURLB",
inputA: "https://www.example.com",
inputB: "ht tp://foo.com",
expectedMatch: false,
expectError: true,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
matched, err := HostnamesMatch(test.inputA, test.inputB)
if test.expectError {
require.Error(t, err)
} else {
require.NoError(t, err)
require.Equal(t, test.expectedMatch, matched)
}
})
}
}