- @lukeheath is interim DRI of API design while @rachaelshaw is out
- @noahtalerman is interim DRI of product reference docs
- @eashaw is also CODEOWNER of `docs/` b/c of doc generation markdown,
structure expertise, and to unblock if Noah is slow to review
---------
Co-authored-by: Eric <eashaw@sailsjs.com>
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
#20059
- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [X] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [X] If database migrations are included, checked table schema to
confirm autoupdate
- For database migrations:
- [X] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [X] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [X] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
- [X] Added/updated tests
- [X] Manual QA for all new/changed functionality
Closes: #17582
Changes:
- Updated the `build-static-content` script to not generate HTML pages
for files in subfolders that are prefixed with an underscore
- Renamed the `docs/Deploy/kubernetes` folder »
`docs/Deploy/_kubernetes`
- Documented this new behavior on the communications page of the
handbook.
- Updated commands on the Deploy Fleet on Kubernetes page.
---------
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
- @noahtalerman get's a Toast notification for changes to dogfood
(managed via [Fleet's best practice
GitOps](https://github.com/fleetdm/fleet-gitops))
Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
This adds Ben back to the codeowners for infra files. This is necessary
because both Kathy and I will be out tomorrow, so no one will be able to
approve Robert's infra changes.
> Note: these changes were originally in
https://github.com/fleetdm/fleet/pull/17450, but were moved into a
separate PR to remove the code owner review requirement from that PR
Changes:
- Updated Andre Shields's job title
- Updated Dan Grzelak's quote (Removed an emoji)
- Updated Erik Gomez's job title
---------
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
- Remove example YAML file from docs to deduplicate
- Update "Prepare a new version of Fleet" handbook instructions to point
to the best practice YAML
- Add README to point to docs
- Move tools for deploying Fleet on Kubernetes to `Deploy/` folder.
- Add @dherder as CODEOWNER so that Dave gets pinged every time a
contributor wants to make a change to the Kubernetes
---------
Co-authored-by: Dave Herder <27025660+dherder@users.noreply.github.com>
Co-authored-by: Luke Heath <luke@fleetdm.com>
Closes: https://github.com/fleetdm/confidential/issues/3521
Changes:
- Added an "all features" option to the pricing mode switch on
fleetdm.com/pricing
- updated the styles and layout of the pricing page to match the latest
wireframes.
---------
Co-authored-by: Mike Thomas <78363703+mike-j-thomas@users.noreply.github.com>
Everyone can contribute to the handbook, and page DRIs are expected to
keep their pages up to date. To shape and absorb changes, and learn from
how GitLab evolved its handbook as that company grew, CEO will ALSO
review all PRs that change the handbook before they are merged.
(Background: As of mid-2023, there are only ≤3 handbook PRs per weekday
on the busiest of weeks. If this increases dramatically, or when time
allows the company to prioritize writing down the content design,
structure, and vision for the evolution of the handbook, we'll change )
---------
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
- Deduplicate config for DRI vs CODEOWNERS (this eliminates extra
notifications folks were receiving)
- auto-remove #g-ceo and #handbook labels when appropriate
- improve comments
https://github.com/fleetdm/confidential/issues/3146
To test this works:
- sam should be able to change ceo handbook and be autoapproved
- mike submitting a PR to the ceo handbook should request review from
Sam but auto-approve for mike
- Jarod's use case of creating an article should now work, even if his
PR contains images
.
---------
Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
