Commit graph

17 commits

Author SHA1 Message Date
Lucas Manuel Rodriguez
4fc731b9b2
Skip CVE in fleetctl (#33267)
Fixes https://github.com/fleetdm/fleet/actions/runs/17906206819.
2025-09-22 18:55:08 -03:00
Lucas Manuel Rodriguez
f16b58d576
Fix vulnerability report in fleetdm/fleet and properly fix in fleetdm… (#33026) 2025-09-16 12:06:45 -05:00
Lucas Manuel Rodriguez
0b0066bfe5
Add VEX rule to remove CVE-2025-27509 false positive on fleetctl (#32914) 2025-09-12 08:54:46 -05:00
Lucas Manuel Rodriguez
e37e14f78d
Generate new osquery 5.18.1 flags, catch up VEX report (#31648)
Adding new flags added to osquery 5.18.1.
2025-08-08 10:49:23 -03:00
jacobshandling
0f94a718d9
UI: Improve names, cleanup unused imports (#30434)
Side quest while doing feature work

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2025-06-30 16:00:22 -07:00
Lucas Manuel Rodriguez
404f0d3ac0
Migrate from aws-sdk-go v1 to v2 (#30308)
#29482

[Migrate to the AWS SDK for Go
v2](https://docs.aws.amazon.com/sdk-for-go/v2/developer-guide/migrate-gosdk.html)
documents how to migrate codebases.

QA on features that use AWS SDK Go:
- Bootstrap package:
  - upload:  
  - download: 
  - cleanup: 
- Software (upload, download, installation, etc.) 
  - Cloudfront: Luckly, this feature was already using aws-sdk-go-v2.
- Carves 
- Logging:
	- Firehose 
	- Kinesis 
- Lambda  (tested result logs to a lambda function on our AWS Dogfood
account)
- Email:
	- Amazon SES TODO ⚠️ (this is what Dogfood uses and a few customers)
- We cannot easily test locally, we can use dogfood or load testing
(AWS) environments.

---

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
- [ ] Manual QA for all new/changed functionality
2025-06-30 17:45:39 -03:00
Lucas Manuel Rodriguez
83961c0d02
Add VEX for CVE-2025-22874 and generate report (#30258)
We missed to add this when we upgraded Go to 1.24.4.
Report
https://github.com/fleetdm/fleet/actions/runs/15626203997/job/44020838145

How to test (with and without the new VEX file):
```
docker scout cves --only-fixed --vex-location=./security/vex/fleet --only-vex-affected --only-severity high,critical fleetdm/fleet:v4.69.0
```
2025-06-25 15:13:34 -03:00
Scott Gress
ed8506dd77
Add VEX statements for libxml2 CVEs (#30011)
This PR adds VEX statement files for three vulverabilities:

```
┌─────────┬────────────────┬──────────┬──────────┬─────────────────────────┬───────────────┬──────────────────────────────────────────────────────────────┐
│ Library │ Vulnerability  │ Severity │  Status  │    Installed Version    │ Fixed Version │                            Title                             │
├─────────┼────────────────┼──────────┼──────────┼─────────────────────────┼───────────────┼──────────────────────────────────────────────────────────────┤
│ libxml2 │ CVE-2025-49794 │ CRITICAL │ affected │ 2.9.14+dfsg-1.3~deb12u1 │               │ libxml: Heap use after free (UAF) leads to Denial of service │
│         │                │          │          │                         │               │ (DoS)...                                                     │
│         │                │          │          │                         │               │ https://avd.aquasec.com/nvd/cve-2025-49794                   │
│         ├────────────────┤          │          │                         ├───────────────┼──────────────────────────────────────────────────────────────┤
│         │ CVE-2025-49795 │          │          │                         │               │ libxml: Null pointer dereference leads to Denial of service  │
│         │                │          │          │                         │               │ (DoS)                                                        │
│         │                │          │          │                         │               │ https://avd.aquasec.com/nvd/cve-2025-49795                   │
│         ├────────────────┤          │          │                         ├───────────────┼──────────────────────────────────────────────────────────────┤
│         │ CVE-2025-49796 │          │          │                         │               │ libxml: Type confusion leads to Denial of service (DoS)      │
│         │                │          │          │                         │               │ https://avd.aquasec.com/nvd/cve-2025-49796                   │
└─────────┴────────────────┴──────────┴──────────┴─────────────────────────┴───────────────┴──────────────────────────────────────────────────────────────┘
```

the vulnerabilities in libxml2 do not affect fleetctl, since the attack
vector is DoS and fleetctl is not a server tool. Additionally the
libxml2 package isn't used by fleetctl directly, but by the tools it
uses for code signing, which don't parse untrusted XML.
2025-06-13 17:00:49 -05:00
Lucas Manuel Rodriguez
1c5700a8c4
Microsoft Compliance Partner backend changes (#29540)
For #27042.

Ready for review, just missing integration tests that I will be writing
today.

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
- [X] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [X] If database migrations are included, checked table schema to
confirm autoupdate
- For new Fleet configuration settings
- [X] Verified that the setting can be managed via GitOps, or confirmed
that the setting is explicitly being excluded from GitOps. If managing
via Gitops:
- [X] Verified that the setting is exported via `fleetctl
generate-gitops`
- [X] Added the setting to [the GitOps
documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485)
- [X] Verified that the setting is cleared on the server if it is not
supplied in a YAML file (or that it is documented as being optional)
- [x] Verified that any relevant UI is disabled when GitOps mode is
enabled
- For database migrations:
- [X] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [X] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [X] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
- [x] Added/updated automated tests
- [X] Manual QA for all new/changed functionality

---------

Co-authored-by: jacobshandling <61553566+jacobshandling@users.noreply.github.com>
Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2025-06-11 14:22:46 -03:00
Ian Littman
ddd7891939
Clean up "click here" and "here" link anchors - part 1 (#29731)
Fixes part of #29720.. Includes promoting some bolded to subheadings (in
wireframe docs).

---------

Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
2025-06-04 13:54:34 -06:00
Lucas Manuel Rodriguez
f982fef35f
Skip CVE-2025-48734 for real (#29743)
I fixed [this](https://github.com/fleetdm/fleet/pull/29692) incorrectly
the first time (my trivy setup is broken on my workstation and I missed
the CI check failure on the original PR).
2025-06-04 01:29:21 -03:00
Lucas Manuel Rodriguez
c771623021
Mark CVE-2025-48734 as not affected (#29692)
https://fleetdm.slack.com/archives/C019WG4GH0A/p1748758788762129
2025-06-02 13:53:40 -03:00
Lucas Manuel Rodriguez
7f85e529be
Iterate status.md for reporting vulnerability updates (#29062)
For #28805.

See scenario we want to support in the linked issue.

---------

Co-authored-by: Scott Gress <scottmgress@gmail.com>
2025-05-15 21:15:37 -03:00
Lucas Manuel Rodriguez
aeddd03733
Amend VEX to support both docker scout and trivy (#28899)
For #28837.
2025-05-07 11:57:00 -03:00
Lucas Manuel Rodriguez
bfe3b186d3
Fix detected CVEs and docker scout exit code to fail the Github Action (#28836)
For #28837.

Fixing this all of this because we got multiple reports from the
community and customers and these were also detected by Amazon
Inspector.

- Fixes CVE-2025-22871 by upgrading Go from 1.24.1 to 1.24.2.
- `docker scout` now fails the daily scheduled action if there are
CRITICAL,HIGH CVEs (we missed setting `exit-code: true`).
- Report CVE-2025-46569 as not affected by it because of our use of
OPA's go package.
- Report CVE-2024-8260 as not affected by it because Fleet doesn't run
on Windows.
- The `security/status.md` shows a lot of changes because we are now
sorting CVEs so that newest come first.

---

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [ ] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [ ] Make sure fleetd is compatible with the latest released version of
Fleet (see [Must
rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/fleetd-development-and-release-strategy.md)).
- [ ] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
- [ ] For unreleased bug fixes in a release candidate, confirmed that
the fix is not expected to adversely impact load test results or alerted
the release DRI if additional load testing is needed.
2025-05-06 13:35:27 -03:00
Lucas Manuel Rodriguez
ffb90d7951
Run make generate-doc (#28595)
PRs are failing due to mismatch in auto-generated docs:

https://github.com/fleetdm/fleet/actions/runs/14685592347/job/41213770932?pr=28531

Co-authored-by: Rachael Shaw <r@rachael.wtf>
2025-04-28 10:11:45 -05:00
Lucas Manuel Rodriguez
895194d63b
Add scanning to released images and process to track vulnerabilities (#28087)
For #25902.

---------

Co-authored-by: Sharon Katz <121527325+sharon-fdm@users.noreply.github.com>
2025-04-16 11:50:10 -03:00