Commit graph

4 commits

Author SHA1 Message Date
Lucas Manuel Rodriguez
7341249025
Fix one-off error in secret variable length check (#32386)
For #32381.
2025-08-27 20:33:22 -03:00
Lucas Manuel Rodriguez
0b0e8c2aa2
Add success notifications for variables (#32251)
Nit: Missing feedback to user after creation or deletion of variables.
Found while testing #29235.

Added similar text used when creating or deleting other entities like
queries or scripts.
2025-08-26 17:45:02 -03:00
Scott Gress
4d31fe1c5e
Custom Variables UI updates (#32304)
for #32269 
for #32271 
for #32285

# Details

This PR addresses some front-end issues found during QA testing of the
new Custom Variables UI

# Checklist for submitter

## Testing

- [X] Added/updated automated tests

- [ ] QA'd all new/changed functionality manually

* Spaces allowed in custom variable values:
<img width="659" height="399" alt="image"
src="https://github.com/user-attachments/assets/e849636f-d91c-4649-a6f1-82bc2397cbbe"
/>

* Overflow in add var modal
<img width="657" height="412" alt="image"
src="https://github.com/user-attachments/assets/d04563e1-df29-457d-976a-b6b05b3aa623"
/>

* If it's too long, show error
<img width="664" height="414" alt="image"
src="https://github.com/user-attachments/assets/91100d0c-35b5-4cd2-a779-6a34bfdc9fc3"
/>

* Overflow in table too
<img width="1031" height="178" alt="image"
src="https://github.com/user-attachments/assets/4833bd64-2f3f-4de7-9392-1955341a5a96"
/>

* Added "Learn More" button and correct margin between tabs and
description
<img width="1053" height="224" alt="image"
src="https://github.com/user-attachments/assets/4db5116c-0a77-4427-ad61-9bde6e94679b"
/>

* Team admins / maintainers can no longer see "Add" or "Delete" var
buttons
<img width="1031" height="374" alt="image"
src="https://github.com/user-attachments/assets/a15ab358-a6de-4d0b-9df9-aa2e7ed5c0cb"
/>

For unreleased bug fixes in a release candidate, one of:

- [X] Confirmed that the fix is not expected to adversely impact load
test results
- [ ] Alerted the release DRI if additional load testing is needed
2025-08-26 14:08:15 -05:00
Scott Gress
2e1ce02796
UI for managing custom variables (#31875)
for #31054

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

## Testing

- [ ] Added/updated automated tests
- [ ] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [X] QA'd all new/changed functionality manually
2025-08-15 08:24:55 -05:00