From fdf89989c54cce26fe0454e716e3a1db674e8722 Mon Sep 17 00:00:00 2001 From: RachelElysia <71795832+RachelElysia@users.noreply.github.com> Date: Mon, 24 Jul 2023 10:46:52 -0400 Subject: [PATCH] Fleet UI: Queries default to alpha order (#12924) --- .../components/PoliciesTable/PoliciesTable.tsx | 2 +- .../ManageAutomationsModal/ManageAutomationsModal.tsx | 8 +++++++- .../components/QueriesTable/QueriesTable.tsx | 7 +++---- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/PoliciesTable.tsx b/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/PoliciesTable.tsx index 033aa29fde..171281c340 100644 --- a/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/PoliciesTable.tsx +++ b/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/PoliciesTable.tsx @@ -22,7 +22,7 @@ const TAGGED_TEMPLATES = { }; const DEFAULT_SORT_DIRECTION = "asc"; -const DEFAULT_SORT_HEADER = "updated_at"; +const DEFAULT_SORT_HEADER = "name"; interface IPoliciesTableProps { policiesList: IPolicyStats[]; diff --git a/frontend/pages/queries/ManageQueriesPage/components/ManageAutomationsModal/ManageAutomationsModal.tsx b/frontend/pages/queries/ManageQueriesPage/components/ManageAutomationsModal/ManageAutomationsModal.tsx index 107267c8e3..0e9d5daae1 100644 --- a/frontend/pages/queries/ManageQueriesPage/components/ManageAutomationsModal/ManageAutomationsModal.tsx +++ b/frontend/pages/queries/ManageQueriesPage/components/ManageAutomationsModal/ManageAutomationsModal.tsx @@ -66,8 +66,14 @@ const ManageAutomationsModal = ({ // TODO: Error handling, if any const [errors, setErrors] = useState<{ [key: string]: string }>({}); + // Client side sort queries alphabetically + const sortedAvailableQueries = + availableQueries?.sort((a, b) => + a.name.toLowerCase().localeCompare(b.name.toLowerCase()) + ) || []; + const { queryItems, updateQueryItems } = useCheckboxListStateManagement( - availableQueries || [], + sortedAvailableQueries, automatedQueryIds || [] ); diff --git a/frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx b/frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx index c3730ad5c1..abb55b687e 100644 --- a/frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx +++ b/frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx @@ -44,8 +44,8 @@ interface IQueriesTableProps { isInherited?: boolean; } -const DEFAULT_SORT_DIRECTION = "desc"; -const DEFAULT_SORT_HEADER = "updated_at"; +const DEFAULT_SORT_DIRECTION = "asc"; +const DEFAULT_SORT_HEADER = "name"; const DEFAULT_PAGE_SIZE = 20; const DEFAULT_PLATFORM = "all"; @@ -99,8 +99,7 @@ const QueriesTable = ({ // Functions to avoid race conditions const initialSearchQuery = (() => queryParams?.query ?? "")(); const initialSortHeader = (() => - (queryParams?.order_key as "updated_at" | "name" | "author") ?? - "updated_at")(); + (queryParams?.order_key as "name" | "updated_at" | "author") ?? "name")(); const initialSortDirection = (() => (queryParams?.order_direction as "asc" | "desc") ?? "asc")(); const initialPlatform = (() =>