mirror of
https://github.com/fleetdm/fleet
synced 2026-05-23 08:58:41 +00:00
DRIs: Drew gets his articles auto-approved and Zay doesn't get pinged every time (#24393)
fyi @zayhanlon if you want to be pinged on every one of these, let Drew know # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features. - [ ] Added/updated tests - [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes - [ ] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [ ] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [ ] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [ ] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [ ] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [ ] Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (`runtime.GOOS`). - [ ] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [ ] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)).
This commit is contained in:
parent
6fe7a6f087
commit
fd56f1cfc8
1 changed files with 2 additions and 2 deletions
4
website/config/custom.js
vendored
4
website/config/custom.js
vendored
|
|
@ -132,7 +132,7 @@ module.exports.custom = {
|
|||
'ee/cis': 'sharon-fdm',//« Fleet Premium only: built-in queries (built-in policies for CIS benchmarks) -- FYI: On 2023-07-15, we changed this so that Sharon, Lucas, and Rachel are all maintainers, but where there is a single DRI who is automatically requested approval from.
|
||||
|
||||
// 🫧 Articles and release notes
|
||||
'articles': ['zayhanlon','drew-p-drawers'],
|
||||
'articles': 'drew-p-drawers',
|
||||
'CHANGELOG.md': 'lukeheath',
|
||||
|
||||
// 🫧 Website (fleetdm.com)
|
||||
|
|
@ -220,7 +220,7 @@ module.exports.custom = {
|
|||
|
||||
// Articles and release notes
|
||||
'CHANGELOG.md': ['mikermcneil', 'noahtalerman', 'lukeheath'],
|
||||
'articles': ['mike-j-thomas', 'eashaw', 'mikermcneil', 'rachaelshaw'],
|
||||
'articles': ['mike-j-thomas', 'eashaw', 'mikermcneil', 'rachaelshaw', 'drew-p-drawers'],
|
||||
'website/assets/images/articles': ['mike-j-thomas', 'eashaw', 'mikermcneil'],
|
||||
|
||||
// Website (fleetdm.com)
|
||||
|
|
|
|||
Loading…
Reference in a new issue