fix brew install warning (#7399)

.github/workflows/fleet-and-orbit.yml

@@ -196,14 +196,19 @@ jobs:
 
     # Docker needs to be installed manually on macOS.
     # From https://github.com/docker/for-mac/issues/2359#issuecomment-943131345
+    # FIXME: lock Docker version to 4.10.0 as newer versions fail to initialize
     - name: Install Docker
+      timeout-minutes: 10
+      if: matrix.os == 'macos-latest'
       run: |
-        # fixme: lock Docker version to 4.10.0 as newer versions fail to initialize
-        curl -L https://raw.githubusercontent.com/Homebrew/homebrew-cask/c65030146a5cf2070c2499b6c68e2c3495c99731/Casks/docker.rb > docker.rb && brew install docker.rb
+        curl -L https://raw.githubusercontent.com/Homebrew/homebrew-cask/c65030146a5cf2070c2499b6c68e2c3495c99731/Casks/docker.rb > docker.rb
+        brew install --cask docker.rb
         sudo /Applications/Docker.app/Contents/MacOS/Docker --unattended --install-privileged-components
         open -a /Applications/Docker.app --args --unattended --accept-license
         echo "Waiting for Docker to start up..."
-        while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do sleep 1; done
+        while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do
+          sleep 1;
+        done
         echo "Docker is ready."
 
     - name: Build Repository and run TUF server

.github/workflows/fleetctl-preview-latest.yml

@@ -33,17 +33,21 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
 
+    # Docker needs to be installed manually on macOS.
+    # From https://github.com/docker/for-mac/issues/2359#issuecomment-943131345
+    # FIXME: lock Docker version to 4.10.0 as newer versions fail to initialize
     - name: Install Docker
-      # Docker needs to be installed manually on macOS.
-      if: contains(matrix.os, 'macos')
-      # From https://github.com/docker/for-mac/issues/2359#issuecomment-943131345
+      timeout-minutes: 10
+      if: matrix.os == 'macos-latest'
       run: |
-        # fixme: lock Docker version to 4.10.0 as newer versions fail to initialize
-        curl -L https://raw.githubusercontent.com/Homebrew/homebrew-cask/c65030146a5cf2070c2499b6c68e2c3495c99731/Casks/docker.rb > docker.rb && brew install docker.rb
+        curl -L https://raw.githubusercontent.com/Homebrew/homebrew-cask/c65030146a5cf2070c2499b6c68e2c3495c99731/Casks/docker.rb > docker.rb
+        brew install --cask docker.rb
         sudo /Applications/Docker.app/Contents/MacOS/Docker --unattended --install-privileged-components
         open -a /Applications/Docker.app --args --unattended --accept-license
         echo "Waiting for Docker to start up..."
-        while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do sleep 1; done
+        while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do
+          sleep 1;
+        done
         echo "Docker is ready."
 
     - name: Install Go
@@ -81,4 +85,4 @@ jobs:
         path: |
           fleet-logs.txt
           orbit.log
-          osquery_result_status_logs
+          osquery_result_status_logs

.github/workflows/fleetctl-preview.yml

@@ -19,17 +19,22 @@ jobs:
         os: [ubuntu-20.04, ubuntu-18.04, macos-11, macos-12]
     runs-on: ${{ matrix.os }}
     steps:
+
+    # Docker needs to be installed manually on macOS.
+    # From https://github.com/docker/for-mac/issues/2359#issuecomment-943131345
+    # FIXME: lock Docker version to 4.10.0 as newer versions fail to initialize
     - name: Install Docker
-      # Docker needs to be installed manually on macOS.
+      timeout-minutes: 10
       if: contains(matrix.os, 'macos')
-      # From https://github.com/docker/for-mac/issues/2359#issuecomment-943131345
       run: |
-        # fixme: lock Docker version to 4.10.0 as newer versions fail to initialize
-        curl -L https://raw.githubusercontent.com/Homebrew/homebrew-cask/c65030146a5cf2070c2499b6c68e2c3495c99731/Casks/docker.rb > docker.rb && brew install docker.rb
+        curl -L https://raw.githubusercontent.com/Homebrew/homebrew-cask/c65030146a5cf2070c2499b6c68e2c3495c99731/Casks/docker.rb > docker.rb
+        brew install --cask docker.rb
         sudo /Applications/Docker.app/Contents/MacOS/Docker --unattended --install-privileged-components
         open -a /Applications/Docker.app --args --unattended --accept-license
         echo "Waiting for Docker to start up..."
-        while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do sleep 1; done
+        while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do
+          sleep 1;
+        done
         echo "Docker is ready."
 
     - name: Start tunnel
@@ -85,4 +90,4 @@ jobs:
         path: |
           fleet-logs.txt
           orbit.log
-          osquery_result_status_logs
+          osquery_result_status_logs

.github/workflows/test-packaging.yml

@@ -29,17 +29,22 @@ jobs:
     runs-on: ${{ matrix.os }}
 
     steps:
+
+    # Docker needs to be installed manually on macOS.
+    # From https://github.com/docker/for-mac/issues/2359#issuecomment-943131345
+    # FIXME: lock Docker version to 4.10.0 as newer versions fail to initialize
     - name: Install Docker
-      timeout-minutes: 60
+      timeout-minutes: 10
       if: matrix.os == 'macos-latest'
-      # From https://github.com/docker/for-mac/issues/2359#issuecomment-943131345
       run: |
-        # fixme: lock Docker version to 4.10.0 as newer versions fail to initialize
-        curl -L https://raw.githubusercontent.com/Homebrew/homebrew-cask/c65030146a5cf2070c2499b6c68e2c3495c99731/Casks/docker.rb > docker.rb && brew install docker.rb
+        curl -L https://raw.githubusercontent.com/Homebrew/homebrew-cask/c65030146a5cf2070c2499b6c68e2c3495c99731/Casks/docker.rb > docker.rb
+        brew install --cask docker.rb
         sudo /Applications/Docker.app/Contents/MacOS/Docker --unattended --install-privileged-components
         open -a /Applications/Docker.app --args --unattended --accept-license
         echo "Waiting for Docker to start up..."
-        while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do sleep 1; done
+        while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do
+          sleep 1;
+        done
         echo "Docker is ready."
 
     - name: Pull fleetdm/wix