Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-22 08:28:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 107

Changed subject name placeholder (#37435)

Browse source 
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #36689

Changed certificate template placeholder to:
```
CN=$FLEET_VAR_HOST_END_USER_IDP_USERNAME, O=Your Organization
```

---------

Co-authored-by: jacobshandling <61553566+jacobshandling@users.noreply.github.com>
This commit is contained in:
Victor Lyuboslavsky 2025-12-17 17:17:32 -06:00 committed by GitHub
parent 7ac24d8752
commit f167aac60d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frontend/pages/ManageControlsPage/OSSettings/cards/Certificates/components/AddCertificateModal/AddCertificateModal.tests.tsx
View file

@ -74,7 +74,7 @@ describe("AddCertModal", () => {
expect(screen.getByText("Certificate authority (CA)")).toBeInTheDocument();
expect(
screen.getByPlaceholderText(
"/CN=$FLEET_VAR_HOST_END_USER_IDP_USERNAME/O=Your Organization"
"CN=$FLEET_VAR_HOST_END_USER_IDP_USERNAME, O=Your Organization"
)
).toBeInTheDocument();
expect(screen.getByText("Create")).toBeInTheDocument();
@ -210,7 +210,7 @@ describe("AddCertModal", () => {
await user.type(nameInput, "Valid Name");
const subjectNameInput = screen.getByPlaceholderText(
"/CN=$FLEET_VAR_HOST_END_USER_IDP_USERNAME/O=Your Organization"
"CN=$FLEET_VAR_HOST_END_USER_IDP_USERNAME, O=Your Organization"
);
await user.type(subjectNameInput, "/CN=test/O=Org");
@ -273,7 +273,7 @@ describe("AddCertModal", () => {
await user.type(nameInput, "Valid Name");
const subjectNameInput = screen.getByPlaceholderText(
"/CN=$FLEET_VAR_HOST_END_USER_IDP_USERNAME/O=Your Organization"
"CN=$FLEET_VAR_HOST_END_USER_IDP_USERNAME, O=Your Organization"
);
await user.type(subjectNameInput, "/CN=test/O=Org");

4
frontend/pages/ManageControlsPage/OSSettings/cards/Certificates/components/AddCertificateModal/AddCertificateModal.tsx
View file

@ -170,9 +170,9 @@ const AddCertModal = ({
value={formData.subjectName}
onChange={onInputChange}
error={formValidation.subjectName?.message}
helpText='Separate subject fields by a "/". For example: /CN=john@example.com/O=Acme Inc.'
helpText='Separate subject fields by ", ". For example: CN=john@example.com, O=Acme Inc.'
parseTarget
placeholder="/CN=$FLEET_VAR_HOST_END_USER_IDP_USERNAME/O=Your Organization"
placeholder="CN=$FLEET_VAR_HOST_END_USER_IDP_USERNAME, O=Your Organization"
/>
<div className="modal-cta-wrap">
<TooltipWrapper