From f135d5b732a4bc7985a51e6db09dbd6c7fa8764b Mon Sep 17 00:00:00 2001
From: jacobshandling <61553566+jacobshandling@users.noreply.github.com>
Date: Tue, 17 Sep 2024 17:04:12 -0400
Subject: [PATCH] =?UTF-8?q?UI=20=E2=80=93=202=20small=20unreleased=20bug?=
 =?UTF-8?q?=20fixes=20for=20software=20install=20policy=20automations=20UI?=
 =?UTF-8?q?=20(#22181)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## 2 small fixes for issues found in QA

- Capitalize word in tooltip
- Correctly render error message, with correctly colored icon

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
---
 .../SoftwarePackageCard/SoftwarePackageCard.tsx          | 4 ++--
 .../SoftwarePage/components/AddPackage/AddPackage.tsx    | 9 ++++++---
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx
index 55e4e7cfdd..30a0578191 100644
--- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx
+++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwarePackageCard/SoftwarePackageCard.tsx
@@ -9,7 +9,7 @@ import { InjectedRouter } from "react-router";
 import PATHS from "router/paths";
 import { AppContext } from "context/app";
 import { NotificationContext } from "context/notification";
-import { SoftwareInstallStatus, ISoftwarePackage } from "interfaces/software";
+import { ISoftwarePackage } from "interfaces/software";
 import softwareAPI from "services/entities/software";
 
 import { buildQueryStringFromParams } from "utilities/url";
@@ -104,7 +104,7 @@ const STATUS_DISPLAY_OPTIONS: Record<
         <br />
         with exit code 0). Currently, if the software is uninstalled, the
         <br />
-        &quot;installed&quot; status won&apos;t be updated.
+        &quot;Installed&quot; status won&apos;t be updated.
       </>
     ),
   },
diff --git a/frontend/pages/SoftwarePage/components/AddPackage/AddPackage.tsx b/frontend/pages/SoftwarePage/components/AddPackage/AddPackage.tsx
index d96b81e69b..df20f7845a 100644
--- a/frontend/pages/SoftwarePage/components/AddPackage/AddPackage.tsx
+++ b/frontend/pages/SoftwarePage/components/AddPackage/AddPackage.tsx
@@ -111,16 +111,19 @@ const AddPackage = ({
       ) {
         renderFlash(
           "error",
-          `${reason}. ${(
+          <>
+            {reason}{" "}
             <CustomLink
               newTab
               url={`${LEARN_MORE_ABOUT_BASE_LINK}/read-package-version`}
               text="Learn more"
+              iconColor="core-fleet-white"
             />
-          )} `
+          </>
         );
+      } else {
+        renderFlash("error", getErrorMessage(e));
       }
-      renderFlash("error", getErrorMessage(e));
     }
 
     onExit();