From e738bae9bb150499cc3565916ee1db74d695b11f Mon Sep 17 00:00:00 2001 From: Mike Thomas <78363703+mike-j-thomas@users.noreply.github.com> Date: Thu, 19 Aug 2021 09:51:01 +0900 Subject: [PATCH] Updated to handbook (#1711) * Updated to handbook Added "Communicating design changes to Engineering" section to the handbook. * Review changes Blockquote for note. Header for unplanned changes. --- handbook/README.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/handbook/README.md b/handbook/README.md index 88205d0cf8..88520fe5c2 100644 --- a/handbook/README.md +++ b/handbook/README.md @@ -50,6 +50,27 @@ For more developed thoughts about __spending guidelines and limits__, please rea * It's okay to spend the first minute or two of a meeting to be present and make small talk, if you want. Being all-remote, it's easy to miss out on hallway chatter and human connections that happen in [meatspace](https://www.dictionary.com/browse/meatspace). Why not use this time together during the first minute to say "hi". Then you can jump right in to the topics being discussed? * Turning on your camera allows for more complete and intuitive verbal and non-verbal communication. When joining meetings with new participants who you might not be familiar with yet, feel free to leave your camera on or to turn it off. When you lead or cohost a meeting, turn your camera on. +### Fleet EE + +##### Communicating design changes to Engineering +For something NEW that has been added to [Figma Fleet EE (current, dev-ready)](https://www.figma.com/file/qpdty1e2n22uZntKUZKEJl/?node-id=0%3A1): +1. Create a new [GitHub issue](https://github.com/fleetdm/fleet/issues/new) +2. Detail the required changes (including page links to the relevant layouts), then assign it to the __“Initiatives”__ project. + +Assign to Initiatives project + +> ___NOTE:__ Artwork and layouts in Figma Fleet EE (current, dev-ready) are final assets, ready for implementation. Therefore, it’s important NOT to use the “idea” label, as designs in this document are more than ideas - they are something that WILL be implemented._ + +3. Navigate to the [Initiatives project](https://github.com/orgs/fleetdm/projects/8), and hit “+ Add cards”, pick the new issue, and drag it into the “🤩Inspire me” column. + +Add cards + +Inspire me + +##### Communicating unplanned design changes + +For issues related to something that was ALREADY in Figma Fleet EE (current, dev-ready), but __implemented differently__, e.g, padding/spacing inconsistency etc. Create a [bug issue](https://github.com/fleetdm/fleet/issues/new?assignees=&labels=bug%2C%3Areproduce&template=bug-report.md&title=) and detail the required changes. + ### Fleet website