Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-23 08:58:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 111

Policy Details/Query Details: No hover state if policy/query is not editable by RBAC (#3368)

Browse source
This commit is contained in:
RachelElysia 2021-12-16 09:54:53 -08:00 committed by GitHub
parent 5aeb418945
commit e60332b8b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changes/issue-3321-spiffier-no-hover-if-not-editable Normal file
View file

@ -0,0 +1 @@
* No hover state for query or policy details if RBAC does not allow editing

1
cypress/integration/free/maintainer.spec.ts
View file

@ -128,6 +128,7 @@ describe(
cy.findByRole("button", { name: /save query pack/i }).click();
cy.visit("/packs/manage");
cy.wait(1000); // eslint-disable-line cypress/no-unnecessary-waiting
cy.get(".fleet-checkbox__input").check({ force: true });

4
cypress/integration/premium/admin.spec.ts
View file

@ -216,6 +216,8 @@ describe(
// On the Settings pages, they should…
// See the “Teams” navigation item and access the Settings - Teams page
cy.visit("/settings/organization");
cy.wait(1000); // eslint-disable-line cypress/no-unnecessary-waiting
cy.get(".react-tabs").within(() => {
cy.findByText(/teams/i).click();
});
@ -236,6 +238,8 @@ describe(
// On the Profile page, they should…
// See Global in the Team section and Admin in the Role section
cy.visit("/profile");
cy.wait(1000); // eslint-disable-line cypress/no-unnecessary-waiting
cy.findByText(/team/i)
.next()
.contains(/global/i);

5
frontend/pages/policies/PolicyPage/components/PolicyForm/_styles.scss
View file

@ -46,16 +46,11 @@
margin: $pad-large 0;
line-height: 2rem;
height: 2rem;
cursor: pointer;
}
.policy-form__policy-resolve,
.resolve-text-wrapper {
margin-top: $pad-large;
}
.policy-form__policy-description:not(textarea),
.policy-form__policy-resolution-button:not(textarea) {
cursor: pointer;
}
#policy-description {
height: 38px;
}

2
frontend/pages/queries/QueryPage/components/QueryForm/_styles.scss
View file

@ -46,11 +46,9 @@
margin-top: $pad-large;
line-height: 2rem;
height: 2rem;
cursor: pointer;
}
.query-form__query-description:not(textarea) {
margin: 0.25rem 0 1rem;
cursor: pointer;
}
textarea.query-form__query-description {
margin-top: 0.8125rem;