From e349f6e205232de8ecf2b21a07699cb65329161e Mon Sep 17 00:00:00 2001 From: Adam Gashlin Date: Fri, 27 Oct 2023 13:08:50 -0700 Subject: [PATCH] Show kickstart flag warning only when set (#13924) The initial implementation of this warning in #12072 used the same `if !c.Bool("disable-kickstart-softwareupdated")` check as the old code, but the body of the `if` was the kickstart which was being skipped, now it is the warning. So currently the warning is showing only when the flag is *not* used. I'm not building this software myself, just an end user who had a version of this assigned to my machine. Since I noticed the warning in logs and figured I'd submit a PR, please feel free to take it over to finish the checklist. --- orbit/cmd/orbit/orbit.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/orbit/cmd/orbit/orbit.go b/orbit/cmd/orbit/orbit.go index ab11ff51f0..3abc9db741 100644 --- a/orbit/cmd/orbit/orbit.go +++ b/orbit/cmd/orbit/orbit.go @@ -347,7 +347,7 @@ func main() { go osservice.SetupServiceManagement(constant.SystemServiceName, systemChecker.svcInterruptCh, appDoneCh) // sofwareupdated is a macOS daemon that automatically updates Apple software. - if !c.Bool("disable-kickstart-softwareupdated") && runtime.GOOS == "darwin" { + if c.Bool("disable-kickstart-softwareupdated") && runtime.GOOS == "darwin" { log.Warn().Msg("fleetd no longer automatically kickstarts softwareupdated. The --disable-kickstart-softwareupdated flag, which was previously used to disable this behavior, has been deprecated and will be removed in a future version") }