From df5d69d2ecc593184051b8be6417c345d82b6814 Mon Sep 17 00:00:00 2001
From: jacobshandling <61553566+jacobshandling@users.noreply.github.com>
Date: Tue, 23 Sep 2025 14:07:50 -0700
Subject: [PATCH] Remove tab counts and update page-level data on each tab
 click (#33367)

## For #33225

(blank host name a known and tracked bug)

https://github.com/user-attachments/assets/5698b8a0-693c-4aae-bc91-9925d856c400


- [x] QA'd all new/changed functionality manually

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
---
 .../ScriptBatchDetailsPage.tsx                | 29 +++++++++----------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/frontend/pages/ManageControlsPage/Scripts/ScriptBatchDetailsPage/ScriptBatchDetailsPage.tsx b/frontend/pages/ManageControlsPage/Scripts/ScriptBatchDetailsPage/ScriptBatchDetailsPage.tsx
index 2676a95e8e..34189cdd89 100644
--- a/frontend/pages/ManageControlsPage/Scripts/ScriptBatchDetailsPage/ScriptBatchDetailsPage.tsx
+++ b/frontend/pages/ManageControlsPage/Scripts/ScriptBatchDetailsPage/ScriptBatchDetailsPage.tsx
@@ -106,7 +106,12 @@ const ScriptBatchDetailsPage = ({
 
   const { renderFlash } = useContext(NotificationContext);
 
-  const { data: batchDetails, isLoading, isError } = useQuery<
+  const {
+    data: batchDetails,
+    isLoading,
+    isError,
+    refetch: refetchBatchDetails,
+  } = useQuery<
     IScriptBatchSummaryV2,
     AxiosError,
     IScriptBatchSummaryV2,
@@ -155,8 +160,10 @@ const ScriptBatchDetailsPage = ({
           .CONTROLS_SCRIPTS_BATCH_DETAILS(batchExecutionId)
           .concat(newQuery ? `?${newQuery}` : "")
       );
+      // update page's summary data (e.g. pct hosts responded) whenever changing tabs
+      refetchBatchDetails();
     },
-    [batchExecutionId, location?.search, router]
+    [batchExecutionId, location?.search, refetchBatchDetails, router]
   );
 
   useEffect(() => {
@@ -279,27 +286,19 @@ const ScriptBatchDetailsPage = ({
           >
             <TabList>
               <Tab>
-                <TabText count={ran}>Ran</TabText>
+                <TabText>Ran</TabText>
               </Tab>
               <Tab>
-                <TabText count={errored} countVariant="alert">
-                  Errored
-                </TabText>
+                <TabText>Errored</TabText>
               </Tab>
               <Tab>
-                <TabText count={pending} countVariant="pending">
-                  Pending
-                </TabText>
+                <TabText>Pending</TabText>
               </Tab>
               <Tab>
-                <TabText count={incompatible} countVariant="pending">
-                  Incompatible
-                </TabText>
+                <TabText>Incompatible</TabText>
               </Tab>
               <Tab>
-                <TabText count={canceled} countVariant="pending">
-                  Canceled
-                </TabText>
+                <TabText>Canceled</TabText>
               </Tab>
             </TabList>
             <TabPanel>