From da697eb0c4a5d47a51ffbd858101d1e4742e46c1 Mon Sep 17 00:00:00 2001
From: Jahziel Villasana-Espinoza <jahziel@fleetdm.com>
Date: Thu, 17 Jul 2025 08:31:36 -0400
Subject: [PATCH] update logic and copy in case of vpp verification failure
 (#30964)

> Closes #30938

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
- [x] For unreleased bug fixes in a release candidate, confirmed that
the fix is not expected to adversely impact load test results or alerted
the release DRI if additional load testing is needed.
---
 .../AppInstallDetails.tests.tsx                 | 17 +++++++++++++++++
 .../AppInstallDetails/AppInstallDetails.tsx     | 13 ++++++++++++-
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/frontend/components/ActivityDetails/InstallDetails/AppInstallDetails/AppInstallDetails.tests.tsx b/frontend/components/ActivityDetails/InstallDetails/AppInstallDetails/AppInstallDetails.tests.tsx
index 34706bd063..ef387135fe 100644
--- a/frontend/components/ActivityDetails/InstallDetails/AppInstallDetails/AppInstallDetails.tests.tsx
+++ b/frontend/components/ActivityDetails/InstallDetails/AppInstallDetails/AppInstallDetails.tests.tsx
@@ -57,6 +57,23 @@ describe("getStatusMessage helper function", () => {
     ).toBeInTheDocument();
   });
 
+  it("shows failed verification message", () => {
+    render(
+      getStatusMessage({
+        displayStatus: "failed_install",
+        isStatusNotNow: false,
+        isStatusAcknowledged: true,
+        software_title: "Logic Pro",
+        host_display_name: "Marko's MacBook Pro",
+      })
+    );
+    expect(
+      screen.getByText(
+        /but the installation has not been verified. Please re-attempt this installation/i
+      )
+    ).toBeInTheDocument();
+  });
+
   it("shows default message for installed status", () => {
     render(
       getStatusMessage({
diff --git a/frontend/components/ActivityDetails/InstallDetails/AppInstallDetails/AppInstallDetails.tsx b/frontend/components/ActivityDetails/InstallDetails/AppInstallDetails/AppInstallDetails.tsx
index 567845981d..c3b7498950 100644
--- a/frontend/components/ActivityDetails/InstallDetails/AppInstallDetails/AppInstallDetails.tsx
+++ b/frontend/components/ActivityDetails/InstallDetails/AppInstallDetails/AppInstallDetails.tsx
@@ -67,7 +67,18 @@ export const getStatusMessage = ({
     );
   }
 
-  // VPP failed state
+  // Verification failed (timeout)
+  if (displayStatus === "failed_install" && isStatusAcknowledged) {
+    return (
+      <>
+        The MDM command (request) to install <b>{software_title}</b> on{" "}
+        {formattedHost} was acknowledged but the installation has not been
+        verified. Please re-attempt this installation.
+      </>
+    );
+  }
+
+  // Install command failed
   if (displayStatus === "failed_install") {
     return (
       <>