Disable orbit osquery extensions on Windows (#3705)

* Disable orbit osquery extensions on Windows

* Add the same to shell.go
This commit is contained in:
Lucas Manuel Rodriguez 2022-01-14 17:42:38 -03:00 committed by GitHub
parent c74d087081
commit d7e2e33e01
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 4 deletions

View file

@ -0,0 +1 @@
* Disabling orbit osquery extensions on Windows until #3679 is fixed.

View file

@ -366,8 +366,11 @@ func main() {
r, _ := osquery.NewRunner(osquerydPath, options...)
g.Add(r.Execute, r.Interrupt)
ext := table.NewRunner(r.ExtensionSocketPath())
g.Add(ext.Execute, ext.Interrupt)
if runtime.GOOS != "windows" {
// We are disabling extensions for Windows until #3679 is fixed.
ext := table.NewRunner(r.ExtensionSocketPath())
g.Add(ext.Execute, ext.Interrupt)
}
// Install a signal handler
ctx, cancel := context.WithCancel(context.Background())

View file

@ -5,6 +5,7 @@ import (
"fmt"
"os"
"path/filepath"
"runtime"
"github.com/fleetdm/fleet/v4/orbit/pkg/constant"
"github.com/fleetdm/fleet/v4/orbit/pkg/osquery"
@ -79,8 +80,11 @@ var shellCommand = &cli.Command{
)
g.Add(r.Execute, r.Interrupt)
ext := table.NewRunner(r.ExtensionSocketPath())
g.Add(ext.Execute, ext.Interrupt)
if runtime.GOOS != "windows" {
// We are disabling extensions for Windows until #3679 is fixed.
ext := table.NewRunner(r.ExtensionSocketPath())
g.Add(ext.Execute, ext.Interrupt)
}
// Install a signal handler
ctx, cancel := context.WithCancel(context.Background())