Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-23 17:08:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 83

Amend community PR process. (#25608)

Browse source
This commit is contained in:
Victor Lyuboslavsky 2025-01-21 11:15:44 -06:00 committed by GitHub
parent 7be88041e1
commit d5e4825f0f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
handbook/engineering/README.md
View file

@ -222,12 +222,17 @@ If you're assigned a community pull request for review, it is important to keep
If the PR is a quick fix (i.e. typo) or obvious technical improvement that doesn't change the product, it can be merged.
For PRs that change the product:
**For PRs that change the product:**
- Assign the PR to the appropriate product group EM (Engineering Manager).
- Notify the EM in the #help-engineering Slack channel.
The EM will be the contact point for the contributor and will ensure the PR is reviewed by the appropriate team member when ready. The EM should:
- Set the PR to draft.
- Thank the contributor for their hard work, explain that all changes to the product go through Fleet's [prioritization process](https://fleetdm.com/handbook/company/product-groups#how-feature-requests-are-prioritized), and ask them to file a [feature request](https://github.com/fleetdm/fleet/issues/new?assignees=&labels=%3Aproduct&projects=&template=feature-request.md&title=) that describe the change their PR is introducing.
For PRs that will not be merged:
**For PRs that will not be merged:**
- Thank the contributor for their effort and explain why the changes won't be merged.
- Close the PR.