From d5370af1b9e1b4d6e5c83d232cc1be2ff1c37d39 Mon Sep 17 00:00:00 2001
From: Victor Lyuboslavsky <victor.lyuboslavsky@gmail.com>
Date: Fri, 15 Nov 2024 12:35:33 -0600
Subject: [PATCH] Frontend changes for NDES issue #23525 (#23829)

#23813
- Frontend changes for NDES issue #23525
---
 .../cards/MdmSettings/ScepPage/ScepPage.tsx   | 26 ++++++++++++++++---
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/ScepPage/ScepPage.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/ScepPage/ScepPage.tsx
index dc1874e637..caea834d89 100644
--- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/ScepPage/ScepPage.tsx
+++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/ScepPage/ScepPage.tsx
@@ -29,9 +29,15 @@ const baseClass = "scep-page";
 
 const BAD_SCEP_URL_ERROR = "Invalid SCEP URL. Please correct and try again.";
 const BAD_CREDENTIALS_ERROR =
-  "Invalid admin URL or credentials. Please correct and try again.";
+  "Couldn't add. Admin URL or credentials are invalid.";
 const CACHE_ERROR =
   "The NDES password cache is full. Please increase the number of cached passwords in NDES and try again. By default, NDES caches 5 passwords and they expire 60 minutes after they are created.";
+const INSUFFICIENT_PERMISSIONS_ERROR =
+  "Couldn't add. This account doesn't have sufficient permissions. Please use the account with enroll permission.";
+const SCEP_URL_TIMEOUT_ERROR =
+  "Couldn't add. Request to NDES (SCEP URL) timed out. Please try again.";
+const ADMIN_URL_TIMEOUT_ERROR =
+  "Couldn't add. Request to NDES (admin URL) timed out. Please try again.";
 const DEFAULT_ERROR =
   "Something went wrong updating your SCEP server. Please try again.";
 
@@ -348,12 +354,24 @@ const ScepPage = ({ router }: IScepPageProps) => {
     } catch (error) {
       console.error(error);
       const reason = getErrorReason(error);
-      if (reason.includes("invalid SCEP URL")) {
-        renderFlash("error", BAD_SCEP_URL_ERROR);
-      } else if (reason.includes("invalid admin URL or credentials")) {
+      if (reason.includes("invalid admin URL or credentials")) {
         renderFlash("error", BAD_CREDENTIALS_ERROR);
       } else if (reason.includes("the password cache is full")) {
         renderFlash("error", CACHE_ERROR);
+      } else if (reason.includes("does not have sufficient permissions")) {
+        renderFlash("error", INSUFFICIENT_PERMISSIONS_ERROR);
+      } else if (
+        reason.includes(formData.scepUrl) &&
+        reason.includes("context deadline exceeded")
+      ) {
+        renderFlash("error", SCEP_URL_TIMEOUT_ERROR);
+      } else if (
+        reason.includes(formData.adminUrl) &&
+        reason.includes("context deadline exceeded")
+      ) {
+        renderFlash("error", ADMIN_URL_TIMEOUT_ERROR);
+      } else if (reason.includes("invalid SCEP URL")) {
+        renderFlash("error", BAD_SCEP_URL_ERROR);
       } else renderFlash("error", DEFAULT_ERROR);
     } finally {
       setIsUpdatingNdesScepProxy(false);