From d4a639414ee6443f81cfb79c761528e6d889706b Mon Sep 17 00:00:00 2001
From: Benjamin Edwards <edwards.benw@gmail.com>
Date: Fri, 31 May 2024 10:47:49 -0400
Subject: [PATCH] use the correct configuration to test for external id
 (#19404)

---
 server/datastore/s3/s3.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/datastore/s3/s3.go b/server/datastore/s3/s3.go
index ebd0e0c3a9..394da53ffa 100644
--- a/server/datastore/s3/s3.go
+++ b/server/datastore/s3/s3.go
@@ -50,7 +50,7 @@ func newS3store(config config.S3Config) (*s3store, error) {
 	// Assume role if configured
 	if config.StsAssumeRoleArn != "" {
 		creds := stscreds.NewCredentials(sess, config.StsAssumeRoleArn, func(provider *stscreds.AssumeRoleProvider) {
-			if config.StsAssumeRoleArn != "" {
+			if config.StsExternalID != "" {
 				provider.ExternalID = &config.StsExternalID
 			}
 		})