Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 09:28:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 31

Renders All Platform Icon if platform is null (#1243)

Browse source
This commit is contained in:
Mike Stone 2017-02-22 11:05:06 -05:00 committed by GitHub
parent 5be9d69165
commit cfc390b179
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frontend/components/queries/ScheduledQueriesList/ScheduledQueriesListItem/ScheduledQueriesListItem.jsx
View file

@ -4,7 +4,7 @@ import Checkbox from 'components/forms/fields/Checkbox';
import ClickableTableRow from 'components/ClickableTableRow';
import Icon from 'components/icons/Icon';
import PlatformIcon from 'components/icons/PlatformIcon';
import { isEqual } from 'lodash';
import { isEmpty, isEqual } from 'lodash';
import scheduledQueryInterface from 'interfaces/scheduled_query';
class ScheduledQueriesListItem extends Component {
@ -52,9 +52,9 @@ class ScheduledQueriesListItem extends Component {
renderPlatformIcon = () => {
const { scheduledQuery: { platform } } = this.props;
const platformArr = platform.split(',');
const platformArr = platform ? platform.split(',') : [];
if (platformArr.includes('all')) {
if (isEmpty(platformArr) || platformArr.includes('all')) {
return <PlatformIcon name="" />;
}

9
frontend/components/queries/ScheduledQueriesList/ScheduledQueriesListItem/ScheduledQueriesListItem.tests.jsx
View file

@ -24,6 +24,15 @@ describe('ScheduledQueriesListItem - component', () => {
expect(component.find('PlatformIcon').length).toEqual(1);
});
it('renders when the platform attribute is null', () => {
const scheduledQuery = { ...scheduledQueryStub, platform: null };
const component = mount(<ScheduledQueriesListItem checked={false} onSelect={noop} scheduledQuery={scheduledQuery} />);
expect(component.text()).toInclude(scheduledQueryStub.name);
expect(component.text()).toInclude(scheduledQueryStub.interval);
expect(component.text()).toInclude(scheduledQueryStub.shard);
expect(component.find('PlatformIcon').length).toEqual(1);
});
it('renders a Checkbox component', () => {
const component = mount(<ScheduledQueriesListItem {...defaultProps} />);
expect(component.find('Checkbox').length).toEqual(1);