From ce15a8189f9bc2eff454d7d3d55c109a81e2a71b Mon Sep 17 00:00:00 2001 From: Noah Talerman <47070608+noahtalerman@users.noreply.github.com> Date: Wed, 1 Dec 2021 14:17:35 -0500 Subject: [PATCH] Update "Operating sytem" modal on the Host details page (#3167) - Update the example policy to use a period `.` instead of a comma `,` - Update the secondary button text to use "Close" instead of "Cancel" - Adjust padding --- frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx | 4 ++-- frontend/pages/hosts/HostDetailsPage/_styles.scss | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx b/frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx index 6184f34966..e7db3a7d97 100644 --- a/frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx +++ b/frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx @@ -353,7 +353,7 @@ const HostDetailsPage = ({ host?.os_version.lastIndexOf(" ") + 1 ); const osPolicyLabel = `Is ${operatingSystem}, version ${operatingSystemVersion} installed?`; - const osPolicy = `SELECT 1 from os_version WHERE name = '${operatingSystem}' AND major || ',' || minor || '.' || patch = '${operatingSystemVersion}';`; + const osPolicy = `SELECT 1 from os_version WHERE name = '${operatingSystem}' AND major || '.' || minor || '.' || patch = '${operatingSystemVersion}';`; const aboutData = normalizeEmptyValues( pick(host, [ @@ -603,7 +603,7 @@ const HostDetailsPage = ({ Create new policy diff --git a/frontend/pages/hosts/HostDetailsPage/_styles.scss b/frontend/pages/hosts/HostDetailsPage/_styles.scss index 27bf646cf9..22499bda85 100644 --- a/frontend/pages/hosts/HostDetailsPage/_styles.scss +++ b/frontend/pages/hosts/HostDetailsPage/_styles.scss @@ -725,6 +725,7 @@ } &__os-modal-title { + padding-right: $pad-medium; font-size: $medium; font-weight: $bold; } @@ -736,6 +737,8 @@ font-weight: $bold; } &__os-policy { + padding-top: $pad-medium; + .form-field__label { font-weight: normal; }