From ccda98d7699f22415a591ace6d67c52c4b753640 Mon Sep 17 00:00:00 2001 From: Gabriel Hernandez Date: Thu, 28 Sep 2023 13:02:27 +0100 Subject: [PATCH] Fix UI script content and output display height. (#14168) relates to #13847 fix max height for script content and output in the script details modal. new max heights: ![image](https://github.com/fleetdm/fleet/assets/1153709/9150c388-850f-4ff8-8117-1a266164e5dc) - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [x] Manual QA for all new/changed functionality --- changes/issue-13847-fix-script-content-and-output-formatting | 1 + changes/issue-13847-fix-script-content-and-output-heights | 1 + .../ActivityFeed/components/ScriptDetailsModal/_styles.scss | 5 ++++- 3 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changes/issue-13847-fix-script-content-and-output-formatting create mode 100644 changes/issue-13847-fix-script-content-and-output-heights diff --git a/changes/issue-13847-fix-script-content-and-output-formatting b/changes/issue-13847-fix-script-content-and-output-formatting new file mode 100644 index 0000000000..0a9bf6bc15 --- /dev/null +++ b/changes/issue-13847-fix-script-content-and-output-formatting @@ -0,0 +1 @@ +- fix script content and output formatting on the scripts detail modal. diff --git a/changes/issue-13847-fix-script-content-and-output-heights b/changes/issue-13847-fix-script-content-and-output-heights new file mode 100644 index 0000000000..07dcf2e0fb --- /dev/null +++ b/changes/issue-13847-fix-script-content-and-output-heights @@ -0,0 +1 @@ +- fix the displayed max-height display for script content and output in the script details modal. diff --git a/frontend/pages/DashboardPage/cards/ActivityFeed/components/ScriptDetailsModal/_styles.scss b/frontend/pages/DashboardPage/cards/ActivityFeed/components/ScriptDetailsModal/_styles.scss index 1158ba1f96..a69a6cb849 100644 --- a/frontend/pages/DashboardPage/cards/ActivityFeed/components/ScriptDetailsModal/_styles.scss +++ b/frontend/pages/DashboardPage/cards/ActivityFeed/components/ScriptDetailsModal/_styles.scss @@ -16,7 +16,8 @@ &__script-content-textarea { box-sizing: border-box; - min-height: 300px; + height: 300px; + overflow-y: auto; font-family: "SourceCodePro"; } @@ -51,5 +52,7 @@ &__output-textarea { font-family: "SourceCodePro"; + max-height: 150px; + overflow: auto; } }