From c5884ae55373ce46300af56dd99bf3f13284ecb1 Mon Sep 17 00:00:00 2001 From: Roberto Dip Date: Tue, 24 Jan 2023 16:53:07 -0300 Subject: [PATCH] fix minor issues in activity items (#9479) This fixes two minor issues for activity items: 1. The value for DEFAULT_GRAVATAR_URL was a transparent square, this uses the same image we use as the fallback for all other avatars. 2. Added a whitespace for MDM activities. --- .../cards/ActivityFeed/ActivityItem/ActivityItem.tsx | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/frontend/pages/DashboardPage/cards/ActivityFeed/ActivityItem/ActivityItem.tsx b/frontend/pages/DashboardPage/cards/ActivityFeed/ActivityItem/ActivityItem.tsx index 6458cd49cb..d9e16518d2 100644 --- a/frontend/pages/DashboardPage/cards/ActivityFeed/ActivityItem/ActivityItem.tsx +++ b/frontend/pages/DashboardPage/cards/ActivityFeed/ActivityItem/ActivityItem.tsx @@ -4,6 +4,7 @@ import { intlFormat, formatDistanceToNowStrict } from "date-fns"; import { ActivityType, IActivity, IActivityDetails } from "interfaces/activity"; import { addGravatarUrlToResource } from "utilities/helpers"; +import { DEFAULT_GRAVATAR_LINK } from "utilities/constants"; import Avatar from "components/Avatar"; import Button from "components/buttons/Button"; import Icon from "components/Icon"; @@ -11,9 +12,6 @@ import ReactTooltip from "react-tooltip"; const baseClass = "activity-item"; -const DEFAULT_GRAVATAR_URL = - "https://www.gravatar.com/avatar/00000000000000000000000000000000?d=blank&size=200"; - const TAGGED_TEMPLATES = { liveQueryActivityTemplate: ( activity: IActivity, @@ -153,7 +151,7 @@ const TAGGED_TEMPLATES = { mdmEnrolled: (activity: IActivity) => { return ( <> - An end user turned on MDM features for a host with serial number + An end user turned on MDM features for a host with serial number{" "} {activity.details?.host_serial} ( {activity.details?.installed_from_dep ? "automatic" : "manual"}) @@ -275,7 +273,7 @@ const ActivityItem = ({ const { actor_email } = activity; const { gravatarURL } = actor_email ? addGravatarUrlToResource({ email: actor_email }) - : { gravatarURL: DEFAULT_GRAVATAR_URL }; + : { gravatarURL: DEFAULT_GRAVATAR_LINK }; const activityCreatedAt = new Date(activity.created_at);