From bc7c5704d4c5e784f2fe98fa81478ee37db47546 Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Mon, 10 Feb 2020 17:32:29 -0800 Subject: [PATCH] server/datastore: fix missing error checks (#2194) Fixing these missing checks did not identify any broken tests or code. --- server/datastore/datastore_hosts_test.go | 1 + server/datastore/datastore_unicode_test.go | 2 ++ 2 files changed, 3 insertions(+) diff --git a/server/datastore/datastore_hosts_test.go b/server/datastore/datastore_hosts_test.go index 107dd7d6e3..8a6a1e3513 100644 --- a/server/datastore/datastore_hosts_test.go +++ b/server/datastore/datastore_hosts_test.go @@ -149,6 +149,7 @@ func testIdempotentDeleteHost(t *testing.T, ds kolide.Datastore) { require.NotNil(t, host) id := host.ID err = ds.DeleteHost(host.ID) + assert.Nil(t, err) host, err = ds.Host(host.ID) assert.NotNil(t, err) diff --git a/server/datastore/datastore_unicode_test.go b/server/datastore/datastore_unicode_test.go index 905df448b8..0b9b6a6ef7 100644 --- a/server/datastore/datastore_unicode_test.go +++ b/server/datastore/datastore_unicode_test.go @@ -35,6 +35,7 @@ func testUnicode(t *testing.T, ds kolide.Datastore) { require.Nil(t, err) host, err = ds.Host(host.ID) + require.Nil(t, err) assert.Equal(t, "🍌", host.HostName) user, err := ds.NewUser(&kolide.User{Username: "🍱", Password: []byte{}}) @@ -47,5 +48,6 @@ func testUnicode(t *testing.T, ds kolide.Datastore) { pack := test.NewPack(t, ds, "👨🏾‍🚒") pack, err = ds.Pack(pack.ID) + require.Nil(t, err) assert.Equal(t, "👨🏾‍🚒", pack.Name) }