Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-23 08:58:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 111

Fix render issue in errors table where the number 0 would be rendered below results table (#354)

Browse source 
This is a visual bug fix.
- Fixes a rendering issue in the Errors table in which the number "0" is rendered below the results table. This rendering issue occurs when the query is completed and no errors are returned.
This commit is contained in:
noahtalerman 2021-02-25 11:42:40 -08:00 committed by GitHub
parent 499cd1d7dc
commit b53d14a37a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
frontend/components/queries/QueryResultsTable/QueryResultsTable.jsx
View file

@ -174,7 +174,7 @@ class QueryResultsTable extends Component {
const { hosts_count: hostsCount, query_results: queryResults, errors } = campaign;
const hasNoResults = !queryIsRunning && (!hostsCount.successful || (!queryResults || !queryResults.length));
const hasErrors = !queryIsRunning && (hostsCount.failed && errors);
const hasErrors = !queryIsRunning && errors;
const resultsTableWrapClass = classnames(baseClass, {
[`${baseClass}--full-screen`]: isQueryFullScreen,
@ -219,12 +219,12 @@ class QueryResultsTable extends Component {
{!hasNoResults && renderTable()}
</div>
{hasErrors &&
<div className={`${baseClass}__error-table-container`}>
<span className={`${baseClass}__table-title`}>Errors</span>
<div className={`${baseClass}__error-table-wrapper`}>
{renderErrorsTable()}
<div className={`${baseClass}__error-table-container`}>
<span className={`${baseClass}__table-title`}>Errors</span>
<div className={`${baseClass}__error-table-wrapper`}>
{renderErrorsTable()}
</div>
</div>
</div>
}
</div>
);