set fix widths on os settings table so we can consistantly show data (#21835)

relates to #7476, #21632

we add fix widths to the columns of the OS Settings modal table so that
we can correctly show the information without UI overflow issues.

**before**


![image](https://github.com/user-attachments/assets/fb4f60c1-a70f-4c4f-a194-2143f98e6ec1)


**after**


![image](https://github.com/user-attachments/assets/2b88619f-f1b6-4c84-ab6e-bace5b584c36)


- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
- [x] Manual QA for all new/changed functionality
This commit is contained in:
Gabriel Hernandez 2024-09-05 17:22:15 +01:00 committed by GitHub
parent 239c69b747
commit b1effeb188
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 15 additions and 5 deletions

View file

@ -0,0 +1 @@
- fixes UI overflow issues with OS settings table data

View file

@ -53,7 +53,7 @@ import {
HOST_OSQUERY_DATA,
} from "utilities/constants";
import { isIPadOrIPhone, Platform } from "interfaces/platform";
import { isIPadOrIPhone } from "interfaces/platform";
import Spinner from "components/Spinner";
import TabsWrapper from "components/TabsWrapper";
@ -479,7 +479,7 @@ const HostDetailsPage = ({
case "ios":
return mdmConfig?.ios_updates;
default:
null;
return undefined;
}
};

View file

@ -43,7 +43,7 @@ const OSSettingsModal = ({
title="OS settings"
onExit={onClose}
className={baseClass}
width="large"
width="xlarge"
>
<>
<OSSettingsTable

View file

@ -15,6 +15,7 @@
}
&__resend-button {
width: 106px;
display: flex;
.children-wrapper {

View file

@ -4,8 +4,15 @@
// for these cells in the table. Total width of the table cell will be
// 240px including the padding.
.data-table-block .data-table tbody td {
.os-settings-name-cell, .os-settings-status-cell, .os-settings-error-cell {
max-width: 192px;
.os-settings-name-cell {
width: 135px;
max-width: none;
}
.os-settings-status-cell {
width: 200px;
}
.os-settings-error-cell {
width: 237px;
}
}

View file

@ -441,6 +441,7 @@ const HostSummary = ({
};
const renderSummary = () => {
console.log(hostMdmProfiles);
// for windows hosts we have to manually add a profile for disk encryption
// as this is not currently included in the `profiles` value from the API
// response for windows hosts.