mirror of
https://github.com/fleetdm/fleet
synced 2026-05-23 00:49:03 +00:00
set fix widths on os settings table so we can consistantly show data (#21835)
relates to #7476, #21632 we add fix widths to the columns of the OS Settings modal table so that we can correctly show the information without UI overflow issues. **before**  **after**  - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - [x] Manual QA for all new/changed functionality
This commit is contained in:
parent
239c69b747
commit
b1effeb188
6 changed files with 15 additions and 5 deletions
1
changes/7476-fix-ui-overflow-os-settings-table
Normal file
1
changes/7476-fix-ui-overflow-os-settings-table
Normal file
|
|
@ -0,0 +1 @@
|
|||
- fixes UI overflow issues with OS settings table data
|
||||
|
|
@ -53,7 +53,7 @@ import {
|
|||
HOST_OSQUERY_DATA,
|
||||
} from "utilities/constants";
|
||||
|
||||
import { isIPadOrIPhone, Platform } from "interfaces/platform";
|
||||
import { isIPadOrIPhone } from "interfaces/platform";
|
||||
|
||||
import Spinner from "components/Spinner";
|
||||
import TabsWrapper from "components/TabsWrapper";
|
||||
|
|
@ -479,7 +479,7 @@ const HostDetailsPage = ({
|
|||
case "ios":
|
||||
return mdmConfig?.ios_updates;
|
||||
default:
|
||||
null;
|
||||
return undefined;
|
||||
}
|
||||
};
|
||||
|
||||
|
|
|
|||
|
|
@ -43,7 +43,7 @@ const OSSettingsModal = ({
|
|||
title="OS settings"
|
||||
onExit={onClose}
|
||||
className={baseClass}
|
||||
width="large"
|
||||
width="xlarge"
|
||||
>
|
||||
<>
|
||||
<OSSettingsTable
|
||||
|
|
|
|||
|
|
@ -15,6 +15,7 @@
|
|||
}
|
||||
|
||||
&__resend-button {
|
||||
width: 106px;
|
||||
display: flex;
|
||||
|
||||
.children-wrapper {
|
||||
|
|
|
|||
|
|
@ -4,8 +4,15 @@
|
|||
// for these cells in the table. Total width of the table cell will be
|
||||
// 240px including the padding.
|
||||
.data-table-block .data-table tbody td {
|
||||
.os-settings-name-cell, .os-settings-status-cell, .os-settings-error-cell {
|
||||
max-width: 192px;
|
||||
.os-settings-name-cell {
|
||||
width: 135px;
|
||||
max-width: none;
|
||||
}
|
||||
.os-settings-status-cell {
|
||||
width: 200px;
|
||||
}
|
||||
.os-settings-error-cell {
|
||||
width: 237px;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -441,6 +441,7 @@ const HostSummary = ({
|
|||
};
|
||||
|
||||
const renderSummary = () => {
|
||||
console.log(hostMdmProfiles);
|
||||
// for windows hosts we have to manually add a profile for disk encryption
|
||||
// as this is not currently included in the `profiles` value from the API
|
||||
// response for windows hosts.
|
||||
|
|
|
|||
Loading…
Reference in a new issue