Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 01:18:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 59

Fleet UI: Label errors (#7406)

Browse source
This commit is contained in:
RachelElysia 2022-08-26 07:55:21 -07:00 committed by GitHub
parent 87e42d4dd8
commit aa3c70be92
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 36 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changes/issue-7196-label-name-description-char-limit Normal file
View file

@ -0,0 +1 @@
* Fleet UI: Show user errors for creating/editing a label with a label name or label description that is too long

32
frontend/pages/hosts/ManageHostsPage/ManageHostsPage.tsx
View file

@ -984,6 +984,22 @@ const ManageHostsPage = ({
setLabelValidator({
name: "A label with this name already exists",
});
} else if (
updateError.data.errors[0].reason.includes(
"Data too long for column 'name'"
)
) {
setLabelValidator({
name: "Label name is too long",
});
} else if (
updateError.data.errors[0].reason.includes(
"Data too long for column 'description'"
)
) {
setLabelValidator({
description: "Label description is too long",
});
} else {
renderFlash("error", "Could not create label. Please try again.");
}
@ -1011,6 +1027,22 @@ const ManageHostsPage = ({
setLabelValidator({
name: "A label with this name already exists",
});
} else if (
updateError.data.errors[0].reason.includes(
"Data too long for column 'name'"
)
) {
setLabelValidator({
name: "Label name is too long",
});
} else if (
updateError.data.errors[0].reason.includes(
"Data too long for column 'description'"
)
) {
setLabelValidator({
description: "Label description is too long",
});
} else {
renderFlash("error", "Could not create label. Please try again.");
}

3
frontend/pages/hosts/ManageHostsPage/components/LabelForm/LabelForm.tsx
View file

@ -66,6 +66,7 @@ const LabelForm = ({
const [description, setDescription] = useState<string>(
selectedLabel?.description || ""
);
const [descriptionError, setDescriptionError] = useState<string>("");
const [query, setQuery] = useState<string>(selectedLabel?.query || "");
const [queryError, setQueryError] = useState<string>("");
const [platform, setPlatform] = useState<string>(
@ -88,6 +89,7 @@ const LabelForm = ({
useEffect(() => {
setNameError(backendValidators.name);
setDescriptionError(backendValidators.description);
}, [backendValidators]);
useEffect(() => {
@ -206,6 +208,7 @@ const LabelForm = ({
placeholder="Label name"
/>
<InputField
error={descriptionError}
name="description"
onChange={onDescriptionChange}
value={description}