From a5af0db138cb434ce30f4562488c6fbd4690d34d Mon Sep 17 00:00:00 2001 From: Andrew Baker <89049099+DrewBakerfdm@users.noreply.github.com> Date: Tue, 29 Aug 2023 18:43:13 -0400 Subject: [PATCH] Remove LinkedIn insight tag (#13531) In order to combat errors with the LinkedIn insight tag, adding version 9 in Google Tag Manager to be published when this PR is merged. This will remove the LinkedIn Insight tag from the footer of layouts.ejs and add the tag to Google Tag Manager instead. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md) - [ ] Documented any permissions changes (docs/Using Fleet/manage-access.md) - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features. - [ ] Added/updated tests - [ ] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [ ] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [ ] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)). --------- Co-authored-by: Eric --- website/views/layouts/layout-customer.ejs | 19 ------------------- website/views/layouts/layout-landing.ejs | 19 ------------------- website/views/layouts/layout-sandbox.ejs | 19 ------------------- website/views/layouts/layout.ejs | 19 ------------------- 4 files changed, 76 deletions(-) diff --git a/website/views/layouts/layout-customer.ejs b/website/views/layouts/layout-customer.ejs index d08bd9661b..923e162f3f 100644 --- a/website/views/layouts/layout-customer.ejs +++ b/website/views/layouts/layout-customer.ejs @@ -185,25 +185,6 @@ <%/* Stripe.js */%> - <%/* Linkedin Ads Insight tag */%> - - - <% /* Delete the global `self` to help avoid client-side bugs. (see https://developer.mozilla.org/en-US/docs/Web/API/Window/self) */ %> diff --git a/website/views/layouts/layout-landing.ejs b/website/views/layouts/layout-landing.ejs index fa3fc55403..8fa143bdd0 100644 --- a/website/views/layouts/layout-landing.ejs +++ b/website/views/layouts/layout-landing.ejs @@ -173,25 +173,6 @@ <%/* Stripe.js */%> - <%/* Linkedin Ads Insight tag */%> - - - <% /* Delete the global `self` to help avoid client-side bugs. (see https://developer.mozilla.org/en-US/docs/Web/API/Window/self) */ %> diff --git a/website/views/layouts/layout-sandbox.ejs b/website/views/layouts/layout-sandbox.ejs index dc0190661b..747d61038d 100644 --- a/website/views/layouts/layout-sandbox.ejs +++ b/website/views/layouts/layout-sandbox.ejs @@ -300,25 +300,6 @@ <%/* Stripe.js */%> - <%/* Linkedin Ads Insight tag */%> - - - <% /* Delete the global `self` to help avoid client-side bugs. (see https://developer.mozilla.org/en-US/docs/Web/API/Window/self) */ %> diff --git a/website/views/layouts/layout.ejs b/website/views/layouts/layout.ejs index 8f2c59cf38..280d60a5c4 100644 --- a/website/views/layouts/layout.ejs +++ b/website/views/layouts/layout.ejs @@ -356,25 +356,6 @@ <%/* Stripe.js */%> - <%/* Linkedin Ads Insight tag */%> - - - <% /* Delete the global `self` to help avoid client-side bugs. (see https://developer.mozilla.org/en-US/docs/Web/API/Window/self) */ %>