From a37d0692b1aa40106a77ab453604b70b45a531f6 Mon Sep 17 00:00:00 2001 From: Lucas Manuel Rodriguez Date: Mon, 10 Jun 2024 16:49:59 -0300 Subject: [PATCH] Fix fleetctl preview bug caused by creating enroll secrets (#19497) #19129 - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [X] Manual QA for all new/changed functionality --- changes/19129-fleetctl-preview-enroll-secrets | 1 + cmd/fleetctl/preview.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changes/19129-fleetctl-preview-enroll-secrets diff --git a/changes/19129-fleetctl-preview-enroll-secrets b/changes/19129-fleetctl-preview-enroll-secrets new file mode 100644 index 0000000000..3851e61a90 --- /dev/null +++ b/changes/19129-fleetctl-preview-enroll-secrets @@ -0,0 +1 @@ +* Fixed bug in `fleetctl preview` caused by creating enroll secrets. diff --git a/cmd/fleetctl/preview.go b/cmd/fleetctl/preview.go index 41aa155dd2..a48734871c 100644 --- a/cmd/fleetctl/preview.go +++ b/cmd/fleetctl/preview.go @@ -407,8 +407,8 @@ Use the stop and reset subcommands to manage the server and dependencies once st return fmt.Errorf("Error retrieving enroll secret: %w", err) } - if len(secrets.Secrets) != 1 { - return errors.New("Expected 1 active enroll secret") + if len(secrets.Secrets) == 0 { + return errors.New("Expected at least one enroll secret") } // disable analytics collection for preview