Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 01:18:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 84

Website: update deliver-apple-csr exits (#30952)

Browse source 
Closes: https://github.com/fleetdm/fleet/issues/30914

Changes:
- Updated the `deliver-apple-csr` endpoint to return a
`csrMissingRequiredValue ` response when the provided unsigned CSR data
does not contain a required value.
This commit is contained in:
Eric 2025-07-16 18:07:19 -05:00 committed by GitHub
parent fc1211436c
commit 9b8d438c63
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
website/api/controllers/deliver-apple-csr.js vendored
View file

@ -37,6 +37,10 @@ module.exports = {
responseType: 'badRequest'
},
csrMissingRequiredValue: {
description: 'The provided unsigned CSR did not contain a required value',
},
badRequest: {
responseType: 'badRequest'
}
@ -83,17 +87,18 @@ module.exports = {
// Parse the JSON result from the mdm-gen-cert command
let generateCertificateResult = JSON.parse(generateCertificateCommand.stdout);
// Throw an error if the result from the mdm-gen-cert command is missing an email value.
// return a csrMissingRequiredValue response if the result from the mdm-gen-cert command is missing an email value.
if(!generateCertificateResult.email) {
throw new Error('When trying to generate a signed CSR for a user, the result from the mdm-gen-cert command did not contain a email.');
throw {'csrMissingRequiredValue': 'The provided unsigned CSR data is missing an "email" value'};
}
// Throw an error if the result from the mdm-gen-cert command is missing an org value.
// return a csrMissingRequiredValue response if the result from the mdm-gen-cert command is missing an org value.
if(!generateCertificateResult.org) {
throw new Error('When trying to generate a signed CSR for a user, the result from the mdm-gen-cert command did not contain an organization name');
throw {'csrMissingRequiredValue': 'The provided unsigned CSR data is missing an "org" value'};
}
// Throw an error if the result from the mdm-gen-cert command is missing an request value.
// return a csrMissingRequiredValue response if the result from the mdm-gen-cert command is missing an request value.
if(!generateCertificateResult.request) {
throw new Error('When trying to generate a signed CSR for a user, the result from the mdm-gen-cert command did not contain a certificate');
throw {'csrMissingRequiredValue': 'The provided unsigned CSR data is missing a "request" value'};
}
// Check to make sure that the email included in the result is a valid email address.