From 99f4faff5168d81ed5dbc1d1fb16f85fad8cabe2 Mon Sep 17 00:00:00 2001 From: Ian Littman Date: Mon, 20 Jan 2025 10:27:48 -0600 Subject: [PATCH] Mention policy automation side effects of VPP token deletion/reassignment (#25584) For #23115. Review requested from @marko-lisica per @noahtalerman's [response](https://github.com/fleetdm/fleet/issues/23115#issuecomment-2599192980) to @jmwatts's comment on the ticket. Skipping changes file as this is part of the larger feature and treated as an unreleased bug for change management purposes, assuming the copy revision looks good (or the copy revision looks good after more modifications). Will assign a dev reviewer once copy looks good, if we decide we want the copy here (vs. in docs). @marko-lisica set for review to confirm whether we need this/whether the copy looks good. @jmwatts set for review to confirm this is what she had in mind for feedback. Of note, deleting a VPP token does _not_ cancel pending installs since at that point the MDM command is already sent, so we don't need that verbiage here. ## Edit VPP token teams ### Before image ### After image ## Delete VPP token ### Before image ### After image # Checklist for submitter - [ ] Manual QA for all new/changed functionality --------- Co-authored-by: Marko Lisica <83164494+marko-lisica@users.noreply.github.com> --- .../VppPage/components/DeleteVppModal/DeleteVppModal.tsx | 3 ++- .../components/EditTeamsVppModal/EditTeamsVppModal.tsx | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/DeleteVppModal/DeleteVppModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/DeleteVppModal/DeleteVppModal.tsx index 8f36149861..7c2700d11c 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/DeleteVppModal/DeleteVppModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/DeleteVppModal/DeleteVppModal.tsx @@ -49,7 +49,8 @@ const DeleteVppModal = ({ <>

Apps purchased for the {orgName} location won't appear in - Fleet. Apps won't be uninstalled from hosts. + Fleet, and policies that trigger automatic install of these apps will + be deleted. Apps won't be uninstalled from hosts.

If you want to enable VPP integration again, you'll have to diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/EditTeamsVppModal/EditTeamsVppModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/EditTeamsVppModal/EditTeamsVppModal.tsx index 27e2d1a425..6953f233a3 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/EditTeamsVppModal/EditTeamsVppModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/EditTeamsVppModal/EditTeamsVppModal.tsx @@ -203,8 +203,9 @@ const EditTeamsVppModal = ({ Edit teams for {currentToken.org_name}.

- If you remove a team, the App Store apps will be removed from that - team. They won't be uninstalled from hosts. + If you delete a team, App Store apps will be deleted from that team, + and policies that trigger automatic install of these apps will be + deleted. Installed apps won't be uninstalled from hosts.