diff --git a/server/service/http_auth_test.go b/server/service/http_auth_test.go index 9a4900775b..4b9880c633 100644 --- a/server/service/http_auth_test.go +++ b/server/service/http_auth_test.go @@ -132,6 +132,7 @@ func TestLogin(t *testing.T) { // ensure that our user's session was deleted from the store sessions, err = ds.ListSessionsForUser(testUser.ID) + assert.Nil(t, err) assert.Len(t, sessions, 0) } } diff --git a/server/service/service_targets_test.go b/server/service/service_targets_test.go index 995b725669..d0bf017150 100644 --- a/server/service/service_targets_test.go +++ b/server/service/service_targets_test.go @@ -70,6 +70,7 @@ func TestSearchWithOmit(t *testing.T) { Name: "label foo", Query: "query foo", }) + require.Nil(t, err) { results, err := svc.SearchTargets(ctx, "foo", nil, nil) diff --git a/server/service/service_test.go b/server/service/service_test.go index 0ec5c992a8..9a9a86915c 100644 --- a/server/service/service_test.go +++ b/server/service/service_test.go @@ -25,6 +25,7 @@ func TestRotateLoggerSIGHUP(t *testing.T) { defer os.Remove(f.Name()) logFile, err := logging.NewFilesystemLogWriter(f.Name(), log.NewNopLogger(), true) + require.Nil(t, err) // write a log line logFile.Write(ctx, []json.RawMessage{json.RawMessage("msg1")}) diff --git a/server/service/service_users_test.go b/server/service/service_users_test.go index 86b0aeee1b..5ee2d2a8e2 100644 --- a/server/service/service_users_test.go +++ b/server/service/service_users_test.go @@ -72,6 +72,7 @@ func TestModifyUserEmail(t *testing.T) { return nil } svc, err := newTestService(ms, nil) + require.Nil(t, err) ctx := context.Background() ctx = viewer.NewContext(ctx, viewer.Viewer{User: user}) payload := kolide.UserPayload{ @@ -107,6 +108,7 @@ func TestModifyUserCannotUpdateAdminEnabled(t *testing.T) { return nil } svc, err := newTestService(ms, nil) + require.Nil(t, err) ctx := context.Background() ctx = viewer.NewContext(ctx, viewer.Viewer{User: user}) payload := kolide.UserPayload{ @@ -148,6 +150,7 @@ func TestModifyUserEmailNoPassword(t *testing.T) { return nil } svc, err := newTestService(ms, nil) + require.Nil(t, err) ctx := context.Background() ctx = viewer.NewContext(ctx, viewer.Viewer{User: user}) payload := kolide.UserPayload{ @@ -195,6 +198,7 @@ func TestModifyAdminUserEmailNoPassword(t *testing.T) { return nil } svc, err := newTestService(ms, nil) + require.Nil(t, err) ctx := context.Background() ctx = viewer.NewContext(ctx, viewer.Viewer{User: user}) payload := kolide.UserPayload{ @@ -242,6 +246,7 @@ func TestModifyAdminUserEmailPassword(t *testing.T) { return nil } svc, err := newTestService(ms, nil) + require.Nil(t, err) ctx := context.Background() ctx = viewer.NewContext(ctx, viewer.Viewer{User: user}) payload := kolide.UserPayload{ @@ -674,6 +679,7 @@ func TestPerformRequiredPasswordReset(t *testing.T) { session, err := ds.NewSession(&kolide.Session{ UserID: user.ID, }) + require.Nil(t, err) ctx = viewer.NewContext(ctx, viewer.Viewer{User: user, Session: session}) // should error when reset not required