update datastore logger (#344)

remove dependency on logrus
adapt go-kit/log interface to gorm logger
allow debug logging flag
This commit is contained in:
Victor Vrantchan 2016-10-25 11:30:14 -04:00 committed by GitHub
parent efffe50a55
commit 950586c100
2 changed files with 14 additions and 8 deletions

View file

@ -3,6 +3,7 @@ package cli
import (
"flag"
"fmt"
"log"
"net/http"
"os"
"os/signal"
@ -69,8 +70,15 @@ the way that the kolide server works.
initFatal(err, "initializing datastore")
}
} else {
var dbOption []datastore.DBOption
gormLogger := log.New(os.Stderr, "", 0)
gormLogger.SetOutput(kitlog.NewStdlibAdapter(logger))
dbOption = append(dbOption, datastore.Logger(gormLogger))
if config.Logging.Debug {
dbOption = append(dbOption, datastore.Debug())
}
connString := datastore.GetMysqlConnectionString(config.Mysql)
ds, err = datastore.New("gorm-mysql", connString)
ds, err = datastore.New("gorm-mysql", connString, dbOption...)
if err != nil {
initFatal(err, "initializing datastore")
}

View file

@ -1,14 +1,12 @@
package datastore
import (
"github.com/Sirupsen/logrus"
"log"
"github.com/kolide/kolide-ose/server/kolide"
)
const (
// TODO @marpaia fix/document default values
defaultMaxAttempts int = 15
)
const defaultMaxAttempts int = 15
// DBOption is used to pass optional arguments to a database connection
type DBOption func(o *dbOptions) error
@ -18,11 +16,11 @@ type dbOptions struct {
maxAttempts int
db kolide.Datastore
debug bool // gorm debug
logger *logrus.Logger
logger *log.Logger
}
// Logger adds a logger to the datastore
func Logger(l *logrus.Logger) DBOption {
func Logger(l *log.Logger) DBOption {
return func(o *dbOptions) error {
o.logger = l
return nil