Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 01:18:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 84

Update comment about how we use redirects & add reminder in user story template (#15520)

Browse source 
Per discussion with @noahtalerman and @marko-lisica today: we're going
to aim to always add redirects in `/website/config/routes.js` for any
docs/external pages we link to in the Fleet UI & CLI, to reduce surface
areas of PRs when doc headings change or things are moved around...

---------

Co-authored-by: Eric <eashaw@sailsjs.com>
This commit is contained in:
Rachael Shaw 2024-01-03 22:58:11 -06:00 committed by GitHub
parent 7d87c6a36c
commit 917e2932e0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/ISSUE_TEMPLATE/story.md vendored
View file

@ -26,7 +26,7 @@ It is [planned and ready](https://fleetdm.com/handbook/company/development-group
- [ ] CLI usage changes: TODO <!-- Specify what changes to the CLI usage are required. Remove this checkbox if there are no changes to the CLI. -->
- [ ] REST API changes: TODO <!-- Specify what changes to the API are required. Remove this checkbox if there are no changes necessary. The product manager may move this item to the engineering list below if they decide that engineering will design the API changes. -->
- [ ] Permissions changes: TODO <!-- Specify what changes to the permissions are required. Remove this checkbox if there are no changes necessary. -->
- [ ] Outdated documentation changes: TODO <!-- Specify required documentation changes. If none, state why. -->
- [ ] Outdated documentation changes: TODO <!-- Specify required documentation changes & redirects to add to /website/config/routes.js. -->
- [ ] Changes to paid features or tiers: TODO <!-- Specify "Fleet Free" or "Fleet Premium". If only certain parts of the user story involve paid features, specify which parts. Implementation of paid features should live in the `ee/` directory. -->
- [ ] Scalability testing: TODO <!-- List any required scalability testing to be conducted. Remove this checkbox if there is no scalability testing required. -->

4
website/config/routes.js vendored
View file

@ -501,8 +501,8 @@ module.exports.routes = {
// Fleet UI
// =============================================================================================================
// These are external links not maintained by Fleet. We can point the Fleet UI to redirects here instead of the
// original sources to help avoid broken links.
// Redirects for external links from the Fleet UI & CLI, including to fleetdm.com and to external websites not
// maintained by Fleet. These help avoid broken links by reducing surface area of links to maintain in the UI.
'GET /learn-more-about/chromeos-updates': 'https://support.google.com/chrome/a/answer/6220366',
'GET /learn-more-about/just-in-time-provisioning': 'https://fleetdm.com/docs/deploy/single-sign-on-sso#just-in-time-jit-user-provisioning',
'GET /sign-in-to/microsoft-automatic-enrollment-tool': 'https://portal.azure.com',