diff --git a/orbit/changes/bug-3563-uninstall-does-not-remove-files b/orbit/changes/bug-3563-uninstall-does-not-remove-files new file mode 100644 index 0000000000..e44a16f20e --- /dev/null +++ b/orbit/changes/bug-3563-uninstall-does-not-remove-files @@ -0,0 +1 @@ +* Windows MSI installer now uses custom actions to remove Orbit files diff --git a/orbit/pkg/packaging/windows_templates.go b/orbit/pkg/packaging/windows_templates.go index d8d65fe9fa..8c113bce16 100644 --- a/orbit/pkg/packaging/windows_templates.go +++ b/orbit/pkg/packaging/windows_templates.go @@ -53,10 +53,6 @@ var windowsWixTemplate = template.Must(template.New("").Option("missingkey=error - - - - @@ -115,12 +111,12 @@ var windowsWixTemplate = template.Must(template.New("").Option("missingkey=error Return="check" Impersonate="no" /> - + Value='"[POWERSHELLEXE]" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -File "[ORBITROOT]installer_utils.ps1" -uninstallOrbit' /> - - (NOT UPGRADINGPRODUCTCODE) AND (REMOVE="ALL") + (NOT UPGRADINGPRODUCTCODE) AND (REMOVE="ALL") NOT Installed AND NOT WIX_UPGRADE_DETECTED -