From 837fef4bc48e1b2d6d0922e0b60bd56fe91c357f Mon Sep 17 00:00:00 2001 From: Roberto Dip Date: Thu, 1 Dec 2022 11:29:07 -0300 Subject: [PATCH] ensure we provide a future date in MSRC test (#8897) This test was failing in Dec 2022, because in this line: ```go _, err := sut.GetFeed((now.AddDate(0, 1, 0)).Month(), now.Year()) ``` `(now.AddDate(0, 1, 0)).Month()` returns `"January"` , and `now.Year()` returns `2022` , so we were sending a date in the past. --- server/vulnerabilities/msrc/io/msrc_test.go | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/server/vulnerabilities/msrc/io/msrc_test.go b/server/vulnerabilities/msrc/io/msrc_test.go index a1f8851af4..26988ef6fd 100644 --- a/server/vulnerabilities/msrc/io/msrc_test.go +++ b/server/vulnerabilities/msrc/io/msrc_test.go @@ -31,9 +31,17 @@ func TestMSRCClient(t *testing.T) { require.Error(t, err) }) - t.Run("provided month and year is in the future", func(t *testing.T) { - _, err := sut.GetFeed((now.AddDate(0, 1, 0)).Month(), now.Year()) - require.Error(t, err) + t.Run("provided arguments are in the future", func(t *testing.T) { + cases := []time.Time{ + now.AddDate(0, 1, 0), + now.AddDate(1, 0, 0), + now.AddDate(1, 1, 0), + } + + for _, c := range cases { + _, err := sut.GetFeed(c.Month(), c.Year()) + require.Error(t, err) + } }) })