Allow reinstallation of MSI packages (#3958)

Make the necessary changes to the WiX XML to allow the generated MSI
installers to be reinstalled.
This commit is contained in:
Zach Wasserman 2022-01-31 16:09:59 -08:00 committed by GitHub
parent 80ef806b2f
commit 80960e47f8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions

1
changes/reinstall-msi Normal file
View file

@ -0,0 +1 @@
* Allow MSI packages generated by `fleetctl package` to reinstall on Windows without uninstall.

View file

@ -8,7 +8,7 @@ var windowsWixTemplate = template.Must(template.New("").Option("missingkey=error
`<?xml version="1.0" encoding="UTF-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi" xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">
<Product
Id="C2C2437D-0562-465E-A0BB-2C4484025BD6"
Id="*"
Name="Fleet osquery"
Language="1033"
Version="{{.Version}}"
@ -16,7 +16,6 @@ var windowsWixTemplate = template.Must(template.New("").Option("missingkey=error
UpgradeCode="B681CB20-107E-428A-9B14-2D3C1AFED244" >
<Package
Id="*"
Keywords='Fleet osquery'
Description="Fleet osquery"
InstallerVersion="500"
@ -25,6 +24,8 @@ var windowsWixTemplate = template.Must(template.New("").Option("missingkey=error
InstallPrivileges="elevated"
Languages="1033" />
<Property Id="REINSTALLMODE" Value="amus" />
<MediaTemplate EmbedCab="yes" />
<MajorUpgrade AllowDowngrades="yes" />